Fix onDidSave event handling
#28
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the extension is activated on an empty workspace, `nova.workspace.activeTextEditor` is `undefined` which raises an unhandled exception. Instead, add an `onDidAddTextEditor` event handler to the workspace and add `onDidSave` to the new `TextEditor` instance.
When the extension is deactivated (or reloaded), we dispose of registered event handlers. This fixes an issue where `onDidSave` would be called twice when a file was reopened and saved after the extension was reloaded.
|
Thanks! I'll review it asap |
|
@tommasongr Can you look at this PR? the unhandled exception is still being raised in nova-rails extension. Locally I'm already using your solar graph extension, and using these 2 extensions side by side works great 👍 |
|
Hi @eirvandelden, I'm sorry if I've not been active recently but I'm currently a bit busy with other work stuff. I'll try to take a look at this and other open issues as soon as I can |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the extension is activated on an empty workspace,
nova.workspace.activeTextEditorisundefinedwhich raises an unhandled exception.Instead, add an
onDidAddTextEditorevent handler to the workspace and addonDidSaveto the newTextEditorinstance.We also clean up event handlers on extension deactivation.
Fixes #27