Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update: Package notation refactoring #191

Merged
merged 32 commits into from
Nov 11, 2022

Conversation

patrickzheng200
Copy link
Contributor

@patrickzheng200 patrickzheng200 commented Nov 8, 2022

PR review order: #190 -> #192 -> This PR -> #186.

This PR refactors the notation package, files intended to be reviewed in this PR:

  1. files in notation folder
  2. internal/mock

internal/common, verification/trustpolicy and verification/truststore pakcages shall be reviewed in #192 already. Therefore, they can be skipped in this PR.

Files in internal/mock_origin, internal/registry, and internal/notation.go are there just for not breaking the old dependencies. They will be removed once the refactoring is done.

Signed-off-by: Patrick Zheng <[email protected]>
Signed-off-by: Patrick Zheng <[email protected]>
Signed-off-by: Patrick Zheng <[email protected]>
Signed-off-by: Patrick Zheng <[email protected]>
notation/notation.go Outdated Show resolved Hide resolved
Signed-off-by: Patrick Zheng <[email protected]>
Signed-off-by: Patrick Zheng <[email protected]>
Signed-off-by: Patrick Zheng <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Nov 9, 2022

Codecov Report

Merging #191 (23a6feb) into main (f9c0b87) will decrease coverage by 2.76%.
The diff coverage is 29.41%.

@@            Coverage Diff             @@
##             main     #191      +/-   ##
==========================================
- Coverage   80.10%   77.34%   -2.77%     
==========================================
  Files          31       33       +2     
  Lines        2071     2189     +118     
==========================================
+ Hits         1659     1693      +34     
- Misses        325      405      +80     
- Partials       87       91       +4     
Impacted Files Coverage Δ
errors.go 0.00% <0.00%> (ø)
signature/envelope.go 100.00% <ø> (ø)
signature/plugin.go 79.25% <ø> (ø)
signature/signer.go 38.23% <ø> (ø)
verification/verifier.go 83.33% <ø> (ø)
notation.go 34.69% <34.69%> (ø)
registry/repository.go 33.84% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

notation/errors.go Outdated Show resolved Hide resolved
notation/errors.go Outdated Show resolved Hide resolved
notation/errors.go Outdated Show resolved Hide resolved
notation/errors.go Outdated Show resolved Hide resolved
notation/notation.go Outdated Show resolved Hide resolved
notation/notation.go Outdated Show resolved Hide resolved
notation/notation.go Outdated Show resolved Hide resolved
notation/notation.go Outdated Show resolved Hide resolved
notation/notation.go Outdated Show resolved Hide resolved
notation/notation.go Outdated Show resolved Hide resolved
Signed-off-by: Patrick Zheng <[email protected]>
Signed-off-by: Patrick Zheng <[email protected]>
Signed-off-by: Patrick Zheng <[email protected]>
Signed-off-by: Patrick Zheng <[email protected]>
Signed-off-by: Patrick Zheng <[email protected]>
notation/notation.go Outdated Show resolved Hide resolved
notation/notation.go Outdated Show resolved Hide resolved
notation/notation.go Outdated Show resolved Hide resolved
notation/notation.go Outdated Show resolved Hide resolved
notation/notation.go Outdated Show resolved Hide resolved
notation/notation.go Outdated Show resolved Hide resolved
notation/notation.go Outdated Show resolved Hide resolved
notation/notation.go Outdated Show resolved Hide resolved
notation/notation.go Outdated Show resolved Hide resolved
notation/notation.go Outdated Show resolved Hide resolved
notation/notation.go Outdated Show resolved Hide resolved
notation/notation.go Outdated Show resolved Hide resolved
notation/notation.go Outdated Show resolved Hide resolved
notation/notation.go Outdated Show resolved Hide resolved
notation.go Show resolved Hide resolved
Signed-off-by: Patrick Zheng <[email protected]>
Signed-off-by: Patrick Zheng <[email protected]>
notation.go Outdated Show resolved Hide resolved
notation.go Outdated Show resolved Hide resolved
notation.go Show resolved Hide resolved
notation.go Outdated Show resolved Hide resolved
notation.go Outdated Show resolved Hide resolved
notation.go Outdated Show resolved Hide resolved
notation.go Outdated Show resolved Hide resolved
notation.go Show resolved Hide resolved
notation.go Outdated Show resolved Hide resolved
notation.go Outdated Show resolved Hide resolved
notation.go Show resolved Hide resolved
notation.go Outdated Show resolved Hide resolved
notation.go Outdated Show resolved Hide resolved
notation.go Outdated Show resolved Hide resolved
notation.go Outdated Show resolved Hide resolved
notation.go Outdated Show resolved Hide resolved
notation.go Show resolved Hide resolved
Signed-off-by: Patrick Zheng <[email protected]>
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Patrick Zheng <[email protected]>
notation.go Outdated Show resolved Hide resolved
notation.go Outdated Show resolved Hide resolved
Signed-off-by: Patrick Zheng <[email protected]>
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

notation.go Outdated Show resolved Hide resolved
notation.go Outdated Show resolved Hide resolved
notation.go Show resolved Hide resolved
Copy link
Contributor

@priteshbandi priteshbandi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with comments addressed.

Signed-off-by: Patrick Zheng <[email protected]>
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Notation-go supporting OCI reference type
8 participants