update: Package registry refactoring #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Patrick Zheng <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #190 +/- ##
==========================================
- Coverage 80.76% 78.07% -2.70%
==========================================
Files 22 22
Lines 1716 1651 -65
==========================================
- Hits 1386 1289 -97
- Misses 258 291 +33
+ Partials 72 71 -1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
This was referenced Nov 8, 2022
JeyJeyGao
reviewed
Nov 8, 2022
shizhMSFT
requested changes
Nov 8, 2022
Signed-off-by: Patrick Zheng <[email protected]>
Signed-off-by: Patrick Zheng <[email protected]>
Signed-off-by: Patrick Zheng <[email protected]>
Signed-off-by: Patrick Zheng <[email protected]>
shizhMSFT
requested changes
Nov 8, 2022
Signed-off-by: Patrick Zheng <[email protected]>
shizhMSFT
reviewed
Nov 9, 2022
Signed-off-by: Patrick Zheng <[email protected]>
priteshbandi
reviewed
Nov 9, 2022
Signed-off-by: Patrick Zheng <[email protected]>
shizhMSFT
reviewed
Nov 9, 2022
Signed-off-by: Patrick Zheng <[email protected]>
Signed-off-by: Patrick Zheng <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR review order: This PR -> #192 -> #191 -> #186
This PR refactors package registry. Please only review files inside the registry folder.
The original registry package is moved into the internal folder. Once this PR is merged, internal/registry shall be removed in a separate PR.
Signed-off-by: Patrick Zheng [email protected]