Add a Bootstrap layout to the CRUD add-on #485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
malparty
force-pushed
the
feature/gh483-crud-addon-add-bootstrap-layout
branch
5 times, most recently
from
de259a3
to
9e57e90
Compare
malparty
commented
Dec 19, 2023
There was a problem hiding this comment.
This file will be reviewed and improved in #491
malparty
force-pushed
the
feature/gh483-crud-addon-add-bootstrap-layout
branch
2 times, most recently
from
53a5378
to
d15961a
Compare
malparty
requested review from
aetheryna,
andyduong1920,
bterone,
byhbt,
carryall,
Goose97,
hoangmirs,
longnd,
vnntsu and
tyrro
as code owners
sanG-github
reviewed
Jan 3, 2024
.template/addons/crud/app/assets/stylesheets/layouts/_application.scss
Outdated
Show resolved
Hide resolved
.template/addons/crud/app/assets/stylesheets/layouts/_application.scss
Outdated
Show resolved
Hide resolved
.template/addons/crud/app/assets/stylesheets/layouts/index.scss
Outdated
Show resolved
Hide resolved
.template/addons/crud/app/views/layouts/application/_nav_bar_top.html.slim
Show resolved
Hide resolved
sanG-github
approved these changes
Jan 7, 2024
malparty
force-pushed
the
feature/gh483-crud-addon-add-bootstrap-layout
branch
from
0243e3d
to
179f653
Compare
4 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What happened 👀
importlines in the root application.scss fileInsight 📝
Important
The purpose of this PR is to get a starting point, not to get the perfect layout 👍
The
look and feelcan be discussed in future issues, I also asked UX team as they have a Figma project for default Rails/Bootstrap apps, but they don't have recommendations fororganism components(e.g. full menu, sidebar, etc...).=> I decided to use the Bootstrap examples from the official doc, so I don't need to think too much about it.
SCSS classes (instead of Bootstrap utility classes) will be implemented in this issue:
Proof Of Work 📹
The Top navbar is responsive, not the sidebar (yet?):