Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#492][CRUD] Add the index view templates to the generator #505

Merged
merged 12 commits into from
Mar 13, 2024
Merged

[#492][CRUD] Add the index view templates to the generator #505

merged 12 commits into from
Mar 13, 2024

Conversation

khangbui22
Copy link
Contributor

@khangbui22 khangbui22 commented Mar 6, 2024 •
edited
Loading

What happened 👀

  • Update Gemfile to use slim-rails instead of slim to be able to generate slim views with slim generator
  • Add lib/template.rb file to copy lib/templates/slim/scaffold/**.tt files to destination
  • Add index.html.slim.tt as the slim template for index view
  • Add tests

Insight 📝

Note

Note that this PR is depended on the #483 PR which handles the adding of CRUD add-on with slim to the template

Proof Of Work 📹

Screen.Recording.2024-03-07.at.09.17.53.mov

@khangbui22 khangbui22 self-assigned this Mar 6, 2024
@khangbui22 khangbui22 changed the base branch from develop to feature/gh483-crud-addon-add-bootstrap-layout March 6, 2024 14:28
@khangbui22 khangbui22 added this to the 5.13.0 milestone Mar 7, 2024
@khangbui22 khangbui22 marked this pull request as ready for review March 7, 2024 02:22
@khangbui22 khangbui22 requested a review from a user March 7, 2024 02:22
Base automatically changed from feature/gh483-crud-addon-add-bootstrap-layout to develop March 7, 2024 07:13
@khangbui22 khangbui22 force-pushed the feature/gh492-crud-addon-index-view-template branch from fdbea78 to b17ce32 Compare March 7, 2024 10:33
malparty
malparty approved these changes Mar 12, 2024
View reviewed changes
Copy link
Member

@malparty malparty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, I finally found the time to test it 🚀

image

@malparty malparty added this pull request to the merge queue Mar 13, 2024
Merged via the queue into develop with commit 688614e Mar 13, 2024
5 checks passed
@malparty malparty deleted the feature/gh492-crud-addon-index-view-template branch March 13, 2024 10:01
@malparty malparty mentioned this pull request Mar 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@malparty malparty malparty approved these changes

@sanG-github sanG-github sanG-github approved these changes

@aetheryna aetheryna Awaiting requested review from aetheryna aetheryna is a code owner

@andyduong1920 andyduong1920 Awaiting requested review from andyduong1920 andyduong1920 is a code owner

@bterone bterone Awaiting requested review from bterone bterone is a code owner

@byhbt byhbt Awaiting requested review from byhbt byhbt is a code owner

@carryall carryall Awaiting requested review from carryall carryall is a code owner

@Goose97 Goose97 Awaiting requested review from Goose97 Goose97 is a code owner

@hoangmirs hoangmirs Awaiting requested review from hoangmirs hoangmirs is a code owner

@longnd longnd Awaiting requested review from longnd longnd is a code owner

@vnntsu vnntsu Awaiting requested review from vnntsu vnntsu is a code owner

@tyrro tyrro Awaiting requested review from tyrro

Assignees

@khangbui22 khangbui22

Labels
type : feature
Projects
None yet
Milestone
5.13.0
Development

Successfully merging this pull request may close these issues.

[CRUD] Add the index view templates to the generator
3 participants
@khangbui22 @sanG-github @malparty