[#316] Upgrade Ruby version #419
Conversation
| docker-api (2.2.0) | ||
| excon (>= 0.47.0) | ||
| multi_json | ||
| excon (0.90.0) | ||
| excon (0.100.0) |
There was a problem hiding this comment.
Need to upgrade the excon to fix the issue on https://github.com/nimblehq/rails-templates/actions/runs/5441234668/jobs/9894962870
An error occurred in a `before(:suite)` hook.
Failure/Error: Docker::Container.get(container_id.strip)
ArgumentError:
The `:host` parameter should not be set for `unix://` connections.
When supplying a `unix://` URI, it should start with `unix:/` or `unix:///`.
andyduong1920
force-pushed
the
feature/upgrade-ruby-version
branch
from
d15cfd9
to
c7e95b6
Compare
| @@ -38,7 +38,8 @@ RUN apt-get update -qq && \ | |||
| ADD https://dl.yarnpkg.com/debian/pubkey.gpg /tmp/yarn-pubkey.gpg | |||
| RUN apt-key add /tmp/yarn-pubkey.gpg && rm /tmp/yarn-pubkey.gpg && \ | |||
| echo "deb http://dl.yarnpkg.com/debian/ stable main" > /etc/apt/sources.list.d/yarn.list && \ | |||
| curl -sL https://deb.nodesource.com/setup_"$NODE_SOURCE_VERSION".x | bash - && \ | |||
| echo 'Package: nodejs\nPin: origin deb.nodesource.com\nPin-Priority: 600' > /etc/apt/preferences.d/nodesource && \ | |||
There was a problem hiding this comment.
As Ruby-3.2.2 slim is based on the Debian-12, and Debian 12 provides a newer Node.js package 18.13.0 from the deb.debian.org repository, so to override the Node.js version, we have to pin the deb.nodesource.com first (source)
andyduong1920
requested review from
rosle,
bterone,
byhbt,
carryall,
hoangmirs,
longnd,
malparty,
tyrro and
sanG-github
as code owners
|
So in the end, not moving to using https://github.com/bkeepers/dotenv? |
As this is a forked version with no guarantee for long-term support, I think it might still be preferable to move with DotEnv. In the meantime, this forked version seems preferable over the non-maintained original gem. 🤔 |
The Removing Figaro issue is still there @olivierobert #394, this PR just solve the #316 they are separate issue, the dotenv replacement seems take longer than the expectation. So to solve the #316 issue, we can go with the fork figaro version first. |
Yeah I added a comment in the Remove Figaro issue, we could replace Figaro with DotENV but I think that is not a small task, we have the draft PR for months already. Btw, this PR is solving the #316 which is just upgrading the Ruby, this doesn't aim to solve the #394 ;) so there are two separate issues ;) |
close #316
What happened 👀
Upgrade Ruby to 3.2.2
Insight 📝
Proof Of Work 📹
The CI is passed