[gh394] Remove the Figaro gem dependency - Andy changes #411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andyduong1920
force-pushed
the
feature/gh394-remove-figaro-gem-dependency-andy
branch
from
c206733
to
07b67f5
Compare
andyduong1920
force-pushed
the
feature/gh394-remove-figaro-gem-dependency-andy
branch
from
f4df671
to
ac3f64f
Compare
|
|
||
| if rails_env == 'production' | ||
| # Read the contents of the .env file | ||
| File.readlines('.env.development.local.example').each do |line| |
There was a problem hiding this comment.
If we build the Docker image, why not using the attribute env_file: https://docs.docker.com/compose/environment-variables/set-environment-variables/#use-the-env_file-attribute
There was a problem hiding this comment.
I tried the env_file but not sure why the ENV can't find there...still need time to figure out @olivierobert :D
| # And it requires the envs as we always use `ENV.fetch` to setup the variables | ||
| # | ||
| # Related issue: https://github.com/rails/rails/issues/32947 | ||
| # TODO: https://github.com/nimblehq/rails-templates/issues/326 |
There was a problem hiding this comment.
Technically, DHH gave a solution that works with a dummy key: rails/rails#32947 (comment)
3 tasks
|
I'm closing this PR as we might not need to remove the figaro way as the new figaro fork solved the issue #419 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #
What happened 👀
Provide a description of the changes this pull request brings to the codebase. Additionally, when the pull request is still being worked on, a checklist of the planned changes is welcome to track progress.
Insight 📝
Describe in detail why this solution is the most appropriate, which solution you tried but did not go with, and how to test the changes. References to relevant documentation are welcome as well.
Proof Of Work 📹
Show us the implementation: screenshots, GIFs, etc.