Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable failing tests in Firefox #2489

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
+21 −7
Open

Disable failing tests in Firefox #2489

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
c86af1e
Disable failing rich-text tests in Firefox
mollykreis Dec 9, 2024
e8b2846
Change files
mollykreis Dec 9, 2024
52730a7
Update table-column-duration-text.spec.ts
mollykreis Dec 9, 2024
97aef4b
Update @ni-nimble-components-b8f24320-d835-42a0-b1d8-1b183206df94.json
mollykreis Dec 9, 2024
10c2ba5
disable more tests
mollykreis Dec 9, 2024
af7b497
Merge branch 'main' into disable-test
jattasNI Dec 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions change/@ni-nimble-components-b8f24320-d835-42a0-b1d8-1b183206df94.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Capturing the plan discussed at standup:
We have a ton of bandwidth available to investigate these failures before the end of the year, but @msmithNI might have time next week. If we see more Firefox failures after this PR goes in then we should consolidate the bugs to a single issue and look into FF-specific fixes rather than test-specific fixes. Maybe we need to shard our FF tests or file memory leak bugs to Mozilla, for example. But for now it seems worth disabling these tests in the hope that the pipeline becomes more stable. Either way we left the bugs with the triage tag so we look at them in the new year.

"type": "none",
"comment": "Disable failing tests in Firefox",
"packageName": "@ni/nimble-components",
"email": "[email protected]",
"dependentChangeType": "none"
}
6 changes: 4 additions & 2 deletions packages/nimble-components/src/rich-text/models/tests/markdown-serializer.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -337,7 +337,8 @@ Plain text 3`);
<user:1> `);
});

it('Mention node', async () => {
// Firefox skipped, see https://github.com/ni/nimble/issues/2488
it('Mention node #SkipFirefox', async () => {
await appendUserMentionConfiguration(element, [
{ key: 'user:1', displayName: 'username1' }
]);
Expand All @@ -347,7 +348,8 @@ Plain text 3`);
expect(element.getMarkdown()).toEqual('<user:1> ');
});

it('Multiple Mention node of same type', async () => {
// Firefox skipped, see https://github.com/ni/nimble/issues/2488
it('Multiple Mention node of same type #SkipFirefox', async () => {
await appendUserMentionConfiguration(element, [
{ key: 'user:1', displayName: 'username1' },
{ key: 'user:2', displayName: 'username2' }
Expand Down
6 changes: 4 additions & 2 deletions ...nimble-components/src/table-column/duration-text/tests/table-column-duration-text.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,8 @@ describe('TableColumnDurationText', () => {
expect(tablePageObject.getCellTitle(0, 0)).toEqual('');
});

it('removes title on mouseout of cell', async () => {
// Firefox skipped, see https://github.com/ni/nimble/issues/2490
it('removes title on mouseout of cell #SkipFirefox', async () => {
table.style.width = '100px';
await table.setData([{ field: 8607022000 }]);
await waitForUpdatesAsync();
Expand All @@ -161,7 +162,8 @@ describe('TableColumnDurationText', () => {
);
});

it('updates displayed date when lang token changes', async () => {
// Firefox skipped, see https://github.com/ni/nimble/issues/2490
it('updates displayed date when lang token changes #SkipFirefox', async () => {
await table.setData([{ field: 8607022000 }]);
await waitForUpdatesAsync();
expect(tablePageObject.getRenderedCellTextContent(0, 0)).toBe(
Expand Down
9 changes: 6 additions & 3 deletions packages/nimble-components/src/table/tests/table.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2620,7 +2620,8 @@ describe('Table', () => {
await waitForUpdatesAsync();
}

it('maintains scroll position if data does not change', async () => {
// Firefox skipped, see https://github.com/ni/nimble/issues/2491
it('maintains scroll position if data does not change #SkipFirefox', async () => {
await setDataAndScrollToBottom(largeData200);
const scrollTopBeforeDisconnect = element.viewport.scrollTop;
const firstRenderedRowBeforeDisconnect = getFirstRenderedRowDataIndex(largeData200);
Expand All @@ -2634,7 +2635,8 @@ describe('Table', () => {
);
});

it('updates scroll position if data length is reduced while not attached', async () => {
// Firefox skipped, see https://github.com/ni/nimble/issues/2491
it('updates scroll position if data length is reduced while not attached #SkipFirefox', async () => {
await setDataAndScrollToBottom(largeData400);
const scrollTopBeforeDisconnect = element.viewport.scrollTop;
const firstRenderedRowBeforeDisconnect = getFirstRenderedRowDataIndex(largeData400);
Expand Down Expand Up @@ -2689,7 +2691,8 @@ describe('Table', () => {
);
});

it('adjusts the number of rendered rows when the table height decreases while not attached', async () => {
// Firefox skipped, see https://github.com/ni/nimble/issues/2491
it('adjusts the number of rendered rows when the table height decreases while not attached #SkipFirefox', async () => {
element.style.height = '500px';
await element.setData(largeData200);
await waitForUpdatesAsync();
Expand Down
Loading