Disable failing tests in Firefox #2489
Open
+21
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mollykreis
changed the title
mollykreis
requested review from
rajsite,
jattasNI and
vivinkrishna-ni
as code owners
jattasNI
approved these changes
Dec 10, 2024
| @@ -0,0 +1,7 @@ | |||
| { | |||
There was a problem hiding this comment.
Capturing the plan discussed at standup:
We have a ton of bandwidth available to investigate these failures before the end of the year, but @msmithNI might have time next week. If we see more Firefox failures after this PR goes in then we should consolidate the bugs to a single issue and look into FF-specific fixes rather than test-specific fixes. Maybe we need to shard our FF tests or file memory leak bugs to Mozilla, for example. But for now it seems worth disabling these tests in the hope that the pipeline becomes more stable. Either way we left the bugs with the triage tag so we look at them in the new year.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
🤨 Rationale
Disabling tests that I saw failing on an unrelated pipeline
Issues have been created to track these failing tests: #2488, #2490, #2491
👩💻 Implementation
N/A
🧪 Testing
N/A
✅ Checklist