Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Executable-fixes #458

Merged
merged 7 commits into from
Nov 18, 2024
Merged

Executable-fixes #458

merged 7 commits into from
Nov 18, 2024

Conversation

robsyme
Copy link
Contributor

@robsyme robsyme commented Nov 17, 2024

At present, there is a mix of executable and non-executable files in the training materials.

This has the potential to confuse some workshop participants as the files will be coloured differently in some console outputs (tree, ls, etc).

At no point do we run the scripts as executables (./main.nf), so the executable bit is unnecessary.

This PR makes:

  • Removes the executable bit from all Nextflow scripts, and
  • Removes the executable bit from other non-executable files (fasta, gz, fq, etc)

Copy link

netlify bot commented Nov 17, 2024

Deploy Preview for nextflow-training ready!

Name Link
🔨 Latest commit 19c739f
🔍 Latest deploy log https://app.netlify.com/sites/nextflow-training/deploys/673a60451449380008d092a7
😎 Deploy Preview https://deploy-preview-458--nextflow-training.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mribeirodantas
Copy link
Member

Good point, @robsyme ! I will merge it, as I don't see any drawback from that. Thanks!

@mribeirodantas mribeirodantas merged commit fa92ba5 into master Nov 18, 2024
8 checks passed
@mribeirodantas mribeirodantas deleted the executable-fixes branch November 18, 2024 00:35
@robsyme
Copy link
Contributor Author

robsyme commented Nov 18, 2024

Thanks @mribeirodantas ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants