Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: workspace tables expand correctly #5591

Merged
merged 2 commits into from
Apr 3, 2024
Merged

fix: workspace tables expand correctly #5591

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2955d8f
fix: workspace tables expand correctly
elzody Mar 27, 2024
092bb31
fix: style lint
elzody Apr 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions src/views/RichWorkspace.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -291,6 +291,25 @@ export default {
margin: 0;
}

#rich-workspace:deep(.table-wrapper .content) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you know why this only affects the rich workspaces?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was wondering that and also trying to dig a bit deeper into it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you know why this only affects the rich workspaces?

Looks like it's actually some styling from Files affecting it - particularly this part: https://github.com/nextcloud/server/blob/6bced389b20e676babbe193c7fbdf77f66433c3a/apps/files/src/components/FilesListVirtual.vue#L409

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All right, that seems reasonable then. While ideally the files app would not have such aggressive rules I also cannot think of an elegant approach to limit the scope properly. Fine with this one here then from my side 👍

tr {
th, td {
flex-grow: 1;
}

th {
div {
width: 100%;
}

.action-item div {
display: flex;
justify-content: flex-end;
}
}
}
}

#rich-workspace:deep(.editor__content) {
margin: 0;
}
Expand Down
Loading