-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: workspace tables expand correctly #5591
Conversation
Signed-off-by: Elizabeth Danzberger <[email protected]>
Signed-off-by: Elizabeth Danzberger <[email protected]>
@@ -291,6 +291,25 @@ export default { | |||
margin: 0; | |||
} | |||
|
|||
#rich-workspace:deep(.table-wrapper .content) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you know why this only affects the rich workspaces?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was wondering that and also trying to dig a bit deeper into it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you know why this only affects the rich workspaces?
Looks like it's actually some styling from Files affecting it - particularly this part: https://github.com/nextcloud/server/blob/6bced389b20e676babbe193c7fbdf77f66433c3a/apps/files/src/components/FilesListVirtual.vue#L409
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All right, that seems reasonable then. While ideally the files app would not have such aggressive rules I also cannot think of an elegant approach to limit the scope properly. Fine with this one here then from my side 👍
/backport to stable29 |
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! |
📝 Summary
🖼️ Screenshots
Before
After
🏁 Checklist
npm run lint
/npm run stylelint
/composer run cs:check
)