-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automatically build sass and sass:icons after build #35622
Conversation
Signed-off-by: John Molakvoæ <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
obsoletes #32753 |
This comment was marked as resolved.
This comment was marked as resolved.
and the workflow that checks if assets were built |
Fair point. |
They are now included in the `postbuild` npm step Signed-off-by: John Molakvoæ <[email protected]>
They are now included in the `postbuild` npm step Signed-off-by: John Molakvoæ <[email protected]>
Is it known that this compiles the scss of all apps? It even touches the git cloned ones. Every time we build the server the independent apps will now have untracked changes. |
@skjnldsv could we read shipped.json and only run scss compilation for the apps in that array? That list should always be up to date. |
Nice idea! Unfortunately this is not really done at that level. We're not invoking a node script. 😞 Most of us do not have cloned apps inside the apps folder. I suggest you use |
I ended up switching to a separate "apps-extra" when I met that issue, haven't had any other since. A more intelligent approach could be worked on separately, if needed. In a more general note, I wonder if we should advise people to always configure a second apps folder, it would make manual upgrades more smooth. |
All the docker devs setups we use are using this. Even for regular setups, I think we should push that forward imho |
With the input above it sounds like this decision has already been made. Could someone please document this critical change for app developers and announce it on the forums so we can all get back to a decent dev setup? |
This comment was marked as outdated.
This comment was marked as outdated.
Raised in nextcloud/standards#9 |
Since it's mandatory, make it automatic
After each
npm run build
the following will be executed:npm run sass
npm run sass:icons