Document frontend sass compilation

[ChristophWurst]

Resolves: n/a

Summary

#32261 changes the compilation of styles but misses documentation for developers.

TODO

• Document the changes

Checklist

• Code is properly formatted
• Sign-off message is added to all commits
• Tests (unit, integration, api and/or acceptance) are included
• Screenshots before/after for front-end changes
• Documentation (manuals or wiki) has been updated or is not required
• Backports requested where applicable (ex: critical bugfixes)

[szaimen]

LGTM but should we also document npm run sass:icons somewhere?

[ChristophWurst]

LGTM but should we also document npm run sass:icons somewhere?

I lack the knowledge to document what it does but makes sense to cover that as well if it's important for contributors.

[szaimen]

I lack the knowledge to document what it does but makes sense to cover that as well if it's important for contributors.

I think it is important if you change some icons but probably makes sense to ask e.g. @skjnldsv for what it does in detail...

[skjnldsv]

I think it is important if you change some icons but probably makes sense to ask e.g. @skjnldsv for what it does in detail...

It generate the mandatory legacy icons.css from https://github.com/nextcloud/server/blob/b9bbb25771fc704d0f5a9de7bc2ae0cae73cf81b/core/src/icons.js

[PVince81]

also when buildling for production, one also needs to run npm run sass && npm run sass:icons, otherwise the diff bot will complain

or is that not necessary any more ?

[skjnldsv]

or is that not necessary any more ?

still is

[skjnldsv]

#35622