Halloween: Cauldron to replace deep fryers

[arimah]

About the PR

• Adds a new entity, the cauldron, which is functionally identical to a deep fryer
• Adds a new HalloweenSystem that effectively migrates all deep fryers to cauldrons, replacing them on map creation

Why / Balance

Spooky witch stuff! Brew things, or something.

The many identical-looking fill levels for the cauldron were added for compatibility with the deep fryer. I could set it to having only a single fill level, but then you can't even see if there's anything in the cauldron until it's full, which isn't ideal. This solution also isn't ideal, but it's for a single day only, so.

The cauldron can be deconstructed and reconstructed to make a normal deep fryer. This is intentional: (1) it gives players a way to "opt out" of the funny meme, (2) I'm too lazy to go and define a unique board for this once-a-year playfulness.

How to test

1. Either set your computer's clock to 31st of October or modify the Halloween holiday to be active on whatever day you're testing this.
2. Spawn on the dev map. The deep fryer should now be a cauldron.
3. Warp to Tinnia's. The deep fryer should now be a cauldron.
4. Warp to Bahama Mama's. The deep fryer should now be a cauldron.
5. Buy a food ship. Its deep fryer should now be a cauldron.
6. Use the cauldron like a normal deep fryer.
7. Deconstruct and reconstruct the cauldron to get a deep fryer.
8. Ensure that the cauldrons on POIs block tool use.
9. Try doing deep dark magic with the cauldron. You know, for science.

Media

2024-10-15.18-14-59.mp4

Requirements

• I have read and am following the Pull Request and Changelog Guidelines.
• I have added media to this PR or it does not require an ingame showcase.

Breaking changes

No.

Changelog
N/A, let people discover as they play the game.

[github-actions]

RSI Diff Bot; head commit 63cc41f merging into cc5c54d
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/_NF/Structures/Machines/cauldron.rsi

State	Old	New	Status
off-0			Added
off-1			Added
off-2			Added
off-3			Added
off-4			Added
off-5			Added
off-6			Added
off-7			Added
off-8			Added
on-1			Added
on-2			Added
on-3			Added
on-4			Added
on-5			Added
on-6			Added
on-7			Added
on-8			Added

Edit: diff updated after 63cc41f

[arimah]

The beautiful sprites were made by Bing Guss and very slightly modified by me.

[whatston3]

Want a spooky shader for ghostly food?

[arimah]

Want a spooky shader for ghostly food?

I love you. Yes.

[dvir001]

This feels like the system can be a more general holiday system but its fine as it is.

[Ansome101]

Might I suggest extending the period that the cauldrons (and any future Halloween items) are available by a few more days? Something to the tune of October 27th-31st would work well, otherwise you'll only see these cauldrons for at best four shifts on Maunder and likely only one on Hypatia. I ask because SS13 servers traditionally have their Halloween mode last a few days to ensure a fair number of players can experience the seasonal content.

[whatston3]

Had to fight with the shared DeepFriedComponent definition, it really doesn't like replicating its own state onto the client when changed on the server. Did get something working though. Also, brings back the "deep-fried" state, and the possibility to describe more through a prototype.

Results are up here: whatston3:halloween-cauldron-spooky-frying

Shader could probably use some work, maybe the brighter something is, the closer it turns to a purplish colour.

Also added a spooky cat (no recipe) to match crispy. Dumb idea, probable trash, but shown for completeness of "this is a deep fryer shader alternative".

[GreaseMonk]

optionally add green glow for extra spook

[GreaseMonk]

PS i will help fix this pr if need be

[GreaseMonk]

In light of new information the conclusion is my comments on this pr are invalidated and there is just no other way . the code spooked me

[arimah]

Okay so, right, okay, so, despite the conversation basically resulting in "the hardcoded entity prototype IDs are okay for now", I had a few minutes to think and came up with a more general solution that would let us trivially add future entity replacements, including more Halloween ones: arimah#1

If you think that's more reasonable (I think it is), I'll update this branch.

[GreaseMonk]

this is awesome 👍🏼 arimah#1 insta merge

[Cheackraze]

yea generecizing it asap would actually probably be good. Like most holiday themed fun PRs, these often get rushed, forced into code, and then swiftly forgotten until the next holiday and we do it again. And, we are heading into holiday season where we will likely have even more use for such a system.