Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Add missing _id suffix to processing status file column mappings #370

Merged
merged 3 commits into from
Nov 4, 2024

Conversation

alyssadai
Copy link
Contributor

@alyssadai alyssadai commented Nov 3, 2024

Changes proposed in this pull request:

Note:
For testing, one thing we could do to catch this kind of error in the future (since we currently maintain these example proc status files) is to request that Nipoppy keep a copy of a reference example processing status file in some repo they can easily update (maybe pipeline-catalog? or in the nipoppy repo itself), and then we can simply grab that file and use it in our tests.

This way, if the schema changes, presumably that example file will change, and our tests should start failing.

Checklist

This section is for the PR reviewer

  • PR has an interpretable title with a prefix ([ENH], [FIX], [REF], [TST], [CI], [MNT], [INF], [MODEL], [DOC]) (see our Contributing Guidelines for more info)
  • PR has a label for the release changelog or skip-release (to be applied by maintainers only)
  • PR links to GitHub issue with mention Closes #XXXX
  • Tests pass
  • Checks pass

For new features:

  • Tests have been added

For bug fixes:

  • There is at least one test that would fail under the original bug conditions.

@alyssadai alyssadai added release Create a release when this PR is merged pr-patch Incremental feature improvement, will increment patch version when merged (0.0.+1) labels Nov 3, 2024
Copy link

codecov bot commented Nov 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.37%. Comparing base (41d87d4) to head (4d576e6).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #370   +/-   ##
=======================================
  Coverage   98.37%   98.37%           
=======================================
  Files          16       16           
  Lines         983      983           
=======================================
  Hits          967      967           
  Misses         16       16           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 11647437352

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 98.372%

Totals Coverage Status
Change from base Build 11604857443: 0.0%
Covered Lines: 967
Relevant Lines: 983

💛 - Coveralls

Copy link
Contributor

@surchs surchs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @alyssadai!

🧑‍🍳

@alyssadai alyssadai merged commit 282cc7d into main Nov 4, 2024
13 checks passed
@alyssadai alyssadai deleted the fix-proc-status-col-names branch November 4, 2024 07:09
Copy link
Contributor

neurobagel-bot bot commented Nov 4, 2024

🚀 PR was released in v0.3.1 🚀

@neurobagel-bot neurobagel-bot bot added the released This issue/pull request has been released. label Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-patch Incremental feature improvement, will increment patch version when merged (0.0.+1) release Create a release when this PR is merged released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CLI expects outdated processing status file column names
3 participants