[FIX] Add missing _id
suffix to processing status file column mappings
#370
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_id
tobids_participant
andbids_session
in example proc status file neurobagel_examples#40Changes proposed in this pull request:
_id
suffix tobids_participant
andbids_session
nipoppy/nipoppy#382, the Nipoppy processing status file now uses column namesbids_participant_id
andbids_session_id
instead ofbids_participant
andbids_session
. This PR brings the column names expected internally by the CLI for this file into alignment with the Nipoppy schema.Note:
For testing, one thing we could do to catch this kind of error in the future (since we currently maintain these example proc status files) is to request that Nipoppy keep a copy of a reference example processing status file in some repo they can easily update (maybe
pipeline-catalog
? or in thenipoppy
repo itself), and then we can simply grab that file and use it in our tests.This way, if the schema changes, presumably that example file will change, and our tests should start failing.
Checklist
This section is for the PR reviewer
[ENH]
,[FIX]
,[REF]
,[TST]
,[CI]
,[MNT]
,[INF]
,[MODEL]
,[DOC]
) (see our Contributing Guidelines for more info)skip-release
(to be applied by maintainers only)Closes #XXXX
For new features:
For bug fixes: