-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] More user-friendly handling of input decoding/reading errors #337
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #337 +/- ##
==========================================
+ Coverage 97.98% 98.06% +0.07%
==========================================
Files 13 13
Lines 746 775 +29
==========================================
+ Hits 731 760 +29
Misses 15 15 ☔ View full report in Codecov by Sentry. |
Pull Request Test Coverage Report for Build 10423411977Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very cool PR, thanks @alyssadai!
I didn't try it out locally, I'm assuming this PR does not change the long stacktraces that typer is printing to the terminal on an error. I left a comment inline about whether our nicely formatted error messages would be hidden by the long stacktraces.
Also some 🍒, take a look.
🧑🍳
🚀 PR was released in |
ValueError
raised when jsonschema validation fails more informative #167Changes proposed in this pull request:
bagel pheno
commandFor reviewer: Any thoughts on whether this should have the
pr-patch
orpr-bug-fix
label?Checklist
This section is for the PR reviewer
[ENH]
,[FIX]
,[REF]
,[TST]
,[CI]
,[MNT]
,[INF]
,[MODEL]
,[DOC]
) (see our Contributing Guidelines for more info)skip-release
(to be applied by maintainers only)Closes #XXXX
For new features:
For bug fixes: