-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MODEL] Update data model to include longitudinal pheno data when sessions exist in TSV #250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aahahaha
Co-written by - Pinning - Sam - Alyssa - Seb - Emille - Naga
Co-authored-by: Alyssa Dai <[email protected]> Co-authored-by: sam-gregz <[email protected]> Co-authored-by: Renee He <[email protected]> Co-authored-by: nagatv11 <[email protected]>
Co-authored-by: Alyssa Dai <[email protected]> Co-authored-by: sam-gregz <[email protected]> Co-authored-by: Renee He <[email protected]> Co-authored-by: nagatv11 <[email protected]>
for more information, see https://pre-commit.ci
Pull Request Test Coverage Report for Build 7184951017
💛 - Coveralls |
alyssadai
commented
Dec 12, 2023
surchs
approved these changes
Dec 12, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what an excellent example of pair programming 👯
🧑🍳
Co-authored-by: Sebastian Urchs <[email protected]>
11 tasks
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
PhenotypicSession
andImagingSession
bagel pheno
command to populate attributes for every session that exists in the input phenotypic TSVbagel bids
command tests to look at only imaging sessions in the outputsession_id
column) in the phenotypic TSV (but this is currently not tested by any tests)Checklist
[ENH]
,[FIX]
,[REF]
,[TST]
,[CI]
,[MNT]
,[INF]
,[MODEL]
,[DOC]
) (see https://neurobagel.org/contributing/pull_requests for more info)Closes #XXXX
For new features:
For bug fixes: