-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] Gracefully handle user providing phenotypic file as .csv #212
Conversation
for now only checks the file ending of the pheno file
Someone sharing a .tsv file that really is a .csv will also get flagged
Pull Request Test Coverage Report for Build 6316815673
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @surchs for addressing this!
Everything seems good functionally, but I've left a few clarification questions and 🍒 comments below I think would be worth having another look at.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two 🍒 suggestions, otherwise looks good to go!!
Co-authored-by: Alyssa Dai <[email protected]>
Closes #90
Changes proposed in this pull request:
.csv
.tsv
file, that really is just a repackaged.csv
file -> we're not fooled 👀Checklist
[ENH]
,[FIX]
,[REF]
,[TST]
,[CI]
,[MNT]
,[INF]
,[MODEL]
,[DOC]
) (see https://neurobagel.org/contributing/pull_requests for more info)Closes #XXXX
For new features:
For bug fixes: