Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Detect categorical column based on annotations #154

Merged
merged 3 commits into from
Jun 10, 2023
Merged

[FIX] Detect categorical column based on annotations #154

merged 3 commits into from
Jun 10, 2023

Conversation

surchs
Copy link
Contributor

@surchs surchs commented Jun 10, 2023 •
edited by rmanaem
Loading

Closes #153
See also #151 and #152

Changes proposed in this pull request:

  • consider a column to be categorical inside the CLI only if there is a "Levels" key in the "Annotations" portion of the data dictionary

Checklist

  • PR has an interpretable title with a prefix ([ENH], [BUG], [DOC], [INFRA], [MAINT])
  • PR links to Github issue with mention Closes #XXXX
  • Tests pass
  • Code is properly formatted

For new features:

  • Tests have been added

For bug fixes:

  • There is at least one test that would fail under the original bug conditions.

@github-actions
Copy link

github-actions bot commented Jun 10, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 5232032548

  • 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.008%) to 99.129%
Totals Coverage Status
Change from base Build 5223804405: 0.008%
Covered Lines: 455
Relevant Lines: 459
💛 - Coveralls

@surchs
Run black
fe732d9 
not sure why my pre-commits are not running
@rmanaem rmanaem self-requested a review June 10, 2023 22:03
rmanaem
rmanaem approved these changes Jun 10, 2023
View reviewed changes
Copy link
Contributor

@rmanaem rmanaem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧑‍🍳

@surchs surchs merged commit e1d6913 into main Jun 10, 2023
@surchs surchs deleted the surchs/issue153 branch June 10, 2023 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rmanaem rmanaem rmanaem approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] correctly annotated column not detected as categorical if the BIDS "Levels" key is missing
2 participants
@surchs @rmanaem