Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows users to toggle between featured and all benchmarks. It also shows the preferred usernames.
Currently, the UI layouts of featured and all benchmarks are still identical, where each benchmark is shown as a card. I was planning to change the layout of all benchmarks to a table (like how systems are displayed) but realized more clarifications are needed. I've put my questions in issue #574 .
Backend
benchmark_featured_list
under DBmetadata
to store the list of featured benchmark ids. This allows admins to maintain the list easily and doesn't require redeployment when the list is modified. Since the list is read-only, it might be even better to store it on Cloud Storage. I might need some pointers on how to create it on GCP 🙏preferred_usernames
as a required field toBenchmarkConfig
inopenapi.yaml
and modified related API endpoints.Frontend
parent_id
andshow_featured
parameters.