Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Benchmark pages: Featured benchmarks and All benchmarks #574

Open
OscarWang114 opened this issue Dec 22, 2022 · 2 comments
Open

Benchmark pages: Featured benchmarks and All benchmarks #574

OscarWang114 opened this issue Dec 22, 2022 · 2 comments
Assignees

Comments

@OscarWang114
Copy link
Collaborator

Hey @neubig @pfliu-nlp I am creating and assigning this issue to me as I would love to complete it. ETA is by the end of this year.

@OscarWang114 OscarWang114 self-assigned this Dec 22, 2022
@neubig
Copy link
Contributor

neubig commented Dec 22, 2022

Sounds great! Thank you.

@OscarWang114
Copy link
Collaborator Author

Hey @neubig @pfliu-nlp, as mentioned in #577 , my question is which layout should we use for child benchmarks (e.g. the benchmarks under global bench)? The problem is it's possible for users to visit child benchmarks from both featured and all benchmarks, but they're using a different layout.

I think it's simpler and makes more sense to use the table layout across all child benchmarks. The card layout will be only used for featured parent benchmarks (by parent I mean the case where parent id == "").

Here's a navigation diagram to provide more clarity.

Case 1: featured (card layout) -> click global bench -> shows global bench's child benchmarks (TABLE layout)

Case 2: all (table layout) -> click global bench -> shows global bench's child benchmarks (TABLE layout)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants