Move precise spike time offset from Event to Time class

[clinssen]

Handle precise spike times by default in many places. This is done by moving the offset member from the Event to the Time class so that is always taken into account when calling Time::get_ms().

This means that plastic synapses will by default take precise spikes into account, so that the warnings added in #2137 can be removed again.

[github-actions]

Pull request automatically marked stale!

[terhorstd]

@clinssen, all mentioned PRs are either merged or closed. Would you be so kind as to comment on the current status of this work, and maybe provide a slightly better description? – Thanks! :)

[heplesser]

@clinssen On my computer, unittests/model_node_init.sli gets stuck in your branch, while it passed on master. Does it also get stuck on your computer?

[clinssen]

model_node_init.sli passes, but my testsuite seems to get stuck (hanging) on regressiontests/issue-1703.py.

[github-actions]

Pull request automatically marked stale!

[JanVogelsang]

Any updates on this PR?

[heplesser]

@JanVogelsang This is high on my agenda, but I would like to integrate deliver-events-first before starting on this. I have a very elegant idea for it.

[terhorstd]

Any updates here?

[heplesser]

Any updates here?

No, delayed due to higher-priority efforts, but not forgotten.

[clinssen]

Comments from @heplesser:

• remove get/set_offset(), use constructors instead and make Time objects immutable
• as some models are absusing the offset field to set a payload: define a set_payload() method on the event; sets offset on the time
• test_stdp_synapse removal should go into a different PR