Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make regular histentry step-based #3307

Open
otcathatsya opened this issue Sep 9, 2024 · 2 comments
Open

Make regular histentry step-based #3307

otcathatsya opened this issue Sep 9, 2024 · 2 comments
Labels
S: Normal Handle this with default priority stale Automatic marker for inactivity, please have another look here T: Maintenance Work to keep up the quality of the code and documentation.

Comments

@otcathatsya
Copy link
Contributor

Right now the regular histentry operates on double, which is only needed for precise spike times. Since the majority of simulations use on-grid simulation steps, it may make sense to change the default to size_t and separate the precise times implementation (potentially through the Time class?).

nest-simulator/nestkernel/histentry.h

Line 40 in b32a3a3

double t_; //!< point in time when spike occurred (in ms)

This would also simplify optimizations relying on grid-locked time steps, e.g. #3247.
@otcathatsya otcathatsya added S: Normal Handle this with default priority T: Maintenance Work to keep up the quality of the code and documentation. labels Sep 9, 2024
@otcathatsya otcathatsya mentioned this issue Sep 9, 2024
Open
@clinssen
Copy link
Contributor

clinssen commented Sep 9, 2024

See also #2035

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 9, 2024

Issue automatically marked stale!

@github-actions github-actions bot added the stale Automatic marker for inactivity, please have another look here label Nov 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
S: Normal Handle this with default priority stale Automatic marker for inactivity, please have another look here T: Maintenance Work to keep up the quality of the code and documentation.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@otcathatsya @clinssen