TASK: #4396 prefer renderingMode::isEdit over node::isLive

[mhsdesign]

Resolves partially #4396
Resolves: #2347

This refactors the isBackend checks in php land to use the defined renderingMode in fusion. Currently the content element wrapping service would otherwise check if the workspace is live and otherwise assume we are in the backend which is wrong. This would cause the content element wrapping to be needlessly rendered in the preview mode (this causes also issues like neos/neos-ui#3144)

Upgrade instructions

Review instructions

Checklist

• Code follows the PSR-2 coding style
• Tests have been created, run and adjusted as needed
• The PR is created against the lowest maintained branch
• Reviewer - PR Title is brief but complete and starts with FEATURE|TASK|BUGFIX
• Reviewer - The first section explains the change briefly for change-logs
• Reviewer - Breaking Changes are marked with !!! and have upgrade-instructions

[kitsunet]

Great idea, thanks!
Buuuuut hold on, this is sadly complicated :/

The chnge would result in rendered stuff in the frontend rendering as well, you might not have noticed this as it is dependent on the Frontendlogin package. If it's installed it prevents the backend user access from being available in the frontend rendering, but without it, this should trigger if your backend user last had selected an edit mode in the backend.

And that is not a desireable side effect.

[mhsdesign]

Hmm you mean flowpack/neos-frontendlogin to be clear? I cant reproduce what you seem to have found.

[kitsunet]

Yep nvm all good, this is prevented by the hardcoded renderingMode set via NodeController::showAction()

[kitsunet]

I guess fine then

[dlubitz]

@mhsdesign It seems this changes breaks rendering of the 404 Not Found page in Neos Demo (Neos.Demo:Document.NotFoundPage)

Exception:

Fatal error: Uncaught AssertionError: assert($renderingMode instanceof RenderingMode) in /var/www/html/Data/Temporary/Development/SubContextDdev/Cache/Code/Flow_Object_Classes/Neos_Neos_Fusion_ConvertUrisImplementation.php:128 Stack trace: #0 /var/www/html/Data/Temporary/Development/SubContextDdev/Cache/Code/Flow_Object_Classes/Neos_Neos_Fusion_ConvertUrisImplementation.php(128): assert(false, 'assert($renderi...') #1 /var/www/html/Data/Temporary/Development/SubContextDdev/Cache/Code/Flow_Object_Classes/Neos_Fusion_Core_Runtime.php(527): Neos\Neos\Fusion\ConvertUrisImplementation_Original->evaluate() #2 /var/www/html/Data/Temporary/Development/SubContextDdev/Cache/Code/Flow_Object_Classes/Neos_Fusion_Core_Runtime.php(479): Neos\Fusion\Core\Runtime_Original->evaluateObjectOrRetrieveFromCache(Object(Neos\Neos\Fusion\ConvertUrisImplementation), 'header<Neos.Dem...', Array, Array) #3 /var/www/html/Data/Temporary/Development/SubContextDdev/Cache/Code/Flow_Object_Classes/Neos_Fusion_Core_Runtime.php(868): Neos\Fusion\Core\Runtime_Original->evaluate('header<Neos.Dem...', Object(Neos\Fusion\FusionObjects\JoinImplementation), 'Exception') #4 /var/www/html/Data/Temporary/Development/SubContextDdev/Cache/Code/Flow_Object_Classes/Neos_Fusion_Core_Runtime.php(534): Neos\Fusion\Core\Runtime_Original->evaluateProcessors('<svg class="hid...', Array, 'header<Neos.Dem...', Object(Neos\Fusion\FusionObjects\JoinImplementation)) #5 /var/www/html/Data/Temporary/Development/SubContextDdev/Cache/Code/Flow_Object_Classes/Neos_Fusion_Core_Runtime.php(479): Neos\Fusion\Core\Runtime_Original->evaluateObjectOrRetrieveFromCache(Object(Neos\Fusion\FusionObjects\JoinImplementation), 'header<Neos.Dem...', Array, Array) #6 /var/www/html/Data/Temporary/Development/SubContextDdev/Cache/Code/Flow_Object_Classes/Neos_Fusion_Core_Runtime.php(314): Neos\Fusion\Core\Runtime_Original->evaluate('header<Neos.Dem...', NULL, 'Exception') #7 /var/www/html/Data/Temporary/Development/SubContextDdev/Cache/Code/Flow_Object_Classes/Neos_Fusion_FusionObjects_ComponentImplementation.php(96): Neos\Fusion\Core\Runtime_Original->render('header<Neos.Dem...') #8 /var/www/html/Data/Temporary/Development/SubContextDdev/Cache/Code/Flow_Object_Classes/Neos_Fusion_FusionObjects_ComponentImplementation.php(46): Neos\Fusion\FusionObjects\ComponentImplementation_Original->render(Array) #9 /var/www/html/Data/Temporary/Development/SubContextDdev/Cache/Code/Flow_Object_Classes/Neos_Fusion_Core_Runtime.php(527): Neos\Fusion\FusionObjects\ComponentImplementation_Original->evaluate() #10 /var/www/html/Data/Temporary/Development/SubContextDdev/Cache/Code/Flow_Object_Classes/Neos_Fusion_Core_Runtime.php(479): Neos\Fusion\Core\Runtime_Original->evaluateObjectOrRetrieveFromCache(Object(Neos\Fusion\FusionObjects\ComponentImplementation), 'header', Array, Array) #11 /var/www/html/Data/Temporary/Development/SubContextDdev/Cache/Code/Flow_Object_Classes/Neos_Fusion_Core_Runtime.php(314): Neos\Fusion\Core\Runtime_Original->evaluate('header', NULL, 'Exception') #12 /var/www/html/Data/Temporary/Development/SubContextDdev/Cache/Code/Flow_Object_Classes/Neos_Fusion_FusionObjects_RendererImplementation.php(58): Neos\Fusion\Core\Runtime_Original->render('header') #13 /var/www/html/Data/Temporary/Development/SubContextDdev/Cache/Code/Flow_Object_Classes/Neos_Fusion_Core_Runtime.php(527): Neos\Fusion\FusionObjects\RendererImplementation_Original->evaluate() #14 /var/www/html/Data/Temporary/Development/SubContextDdev/Cache/Code/Flow_Object_Classes/Neos_Fusion_Core_Runtime.php(479): Neos\Fusion\Core\Runtime_Original->evaluateObjectOrRetrieveFromCache(Object(Neos\Fusion\FusionObjects\RendererImplementation), 'root<Neos.Fusio...', Array, Array) #15 /var/www/html/Packages/Neos/Neos.Fusion/Classes/FusionObjects/Helpers/LazyProps.php(69): Neos\Fusion\Core\Runtime_Original->evaluate('root<Neos.Fusio...', Object(Neos\Fusion\FusionObjects\ComponentImplementation)) #16 /var/www/html/Packages/Neos/Neos.Fusion/Classes/FusionObjects/Helpers/LazyProps.php(93): Neos\Fusion\FusionObjects\Helpers\LazyProps->offsetGet('header') #17 [internal function]: Neos\Fusion\FusionObjects\Helpers\LazyProps->current() #18 /var/www/html/Packages/Neos/Neos.Fusion/Classes/FusionObjects/Helpers/LazyProps.php(118): iterator_to_array(Object(Neos\Fusion\FusionObjects\Helpers\LazyProps)) #19 [internal function]: Neos\Fusion\FusionObjects\Helpers\LazyProps->jsonSerialize() #20 /var/www/html/Packages/Framework/Neos.Flow/Classes/Error/Debugger.php(478): json_encode(Object(Neos\Fusion\FusionObjects\Helpers\LazyProps), 512, 1) #21 /var/www/html/Packages/Framework/Neos.Flow/Classes/Error/Debugger.php(341): Neos\Flow\Error\Debugger::getObjectSnippetPlaintext(Object(Neos\Fusion\FusionObjects\Helpers\LazyProps)) #22 /var/www/html/Packages/Framework/Neos.Flow/Classes/Error/DebugExceptionHandler.php(130): Neos\Flow\Error\Debugger::getBacktraceCode(Array) #23 /var/www/html/Packages/Framework/Neos.Flow/Classes/Error/DebugExceptionHandler.php(81): Neos\Flow\Error\DebugExceptionHandler->renderStatically(404, Object(AssertionError)) #24 /var/www/html/Packages/Framework/Neos.Flow/Classes/Error/AbstractExceptionHandler.php(128): Neos\Flow\Error\DebugExceptionHandler->echoExceptionWeb(Object(Neos\Flow\Mvc\Controller\Exception\InvalidControllerException)) #25 [internal function]: Neos\Flow\Error\AbstractExceptionHandler->handleException(Object(Neos\Flow\Mvc\Controller\Exception\InvalidControllerException)) #26 {main} thrown in /var/www/html/Data/Temporary/Development/SubContextDdev/Cache/Code/Flow_Object_Classes/Neos_Neos_Fusion_ConvertUrisImplementation.php on line 128

Is this a Neos or Neos.Demo issue?

[mhsdesign]

nope puuuhh i was not aware of that thanks ;)

#4824