BUGFIX: Serialised node fully qualified for fusion uncached mode

[mhsdesign]

Resolves: #4732

discussion should happen in #4732 and once we agree on a solution i will update this pr description

Upgrade instructions

Review instructions

test that this works:

prototype(Neos.Demo:Content.Headline) < prototype(Neos.Neos:ContentComponent) {
    renderer = afx`...`

    @cache {
        mode = 'uncached'
        context {
            1 = 'node'
        }
    }
}

Checklist

• Code follows the PSR-2 coding style
• Tests have been created, run and adjusted as needed
• The PR is created against the lowest maintained branch
• Reviewer - PR Title is brief but complete and starts with FEATURE|TASK|BUGFIX
• Reviewer - The first section explains the change briefly for change-logs
• Reviewer - Breaking Changes are marked with !!! and have upgrade-instructions

[kitsunet]

not a fan doing this specifically for fusion/the property mapper, why don't we replace the serialization format here \Neos\Neos\FrontendRouting\NodeAddress::serializeForUri with a fully qualified one?

[kitsunet]

Or yes, we introduce NodeIdentity and drop the serialization format from NodeAddress, that would be even neater

-> #4564

[mhsdesign]

Yes a NodeIdentity is the solution. And then we make use of json_serialise directly like the value object support for flow_json_array :D

[mhsdesign]

Solved it by removing the hardcoded property mapper from the fusion cache and using symfony's interfaces

[kitsunet]

Wait what do we gain here? Another object? Like apart from abstracting the propertyMapper away here nothing has changed?

[mhsdesign]

Oh this isnt just a new object.
This is so much more than an object :D

By adding a layer of abstraction Fusion standalone will use the property mapper yes, but Neos.Neos implements an own serialiser so that it can serialise nodes without bothering the propertymapper.
That allows us to remove property mapping for nodes e.g. NewNodeConverter and its college.
In my opinion its super important that people dont accidentally use the property mapper with the new nodes.
Allowing mapping would render all of our strictness and new explicitness useless as it would allow again magical nodes in controllers:

public function nodeAction(Node $node): {}

which will already now confusion for example about the nodes format when serialised ...

Lets to it rather explicit this time please :D

[kitsunet]

Allowing mapping would render all of our strictness and new explicitness useless as it would allow again magical nodes in controllers:

I think that is a core expectation though, countless projects will have controllers expecting a node and I don#t see why for the time being as the propertyMapper IS still the suggested and only way to do controller marshalling build into Flow, this should work

[mhsdesign]

Huh i didnt know we werent on the same side :D I thought we discussed this already someplace but couldnt find it so i opened a separate issue: #4873

Under that aspect, i will revert the removal of the property mappers with this pr.

[mhsdesign]

We discussed that we dislike property mapping directly to a node via the flow property mapper. For fusion we have the usecase of unserialising the node @cache.context { 0 = 'node' }.
So injecting a dedicated specialised serialiser into the RuntimeContent cache should be the first step.
As followup as part of #4564 we should unify the node serialisation across all places.

[mhsdesign]

This is now ready for review. Once we have a central NodeIdentity i will adjust the code to use that serialiser from the NeosFusionContextSerializer.
So please review the pr under that aspect and see if the general concepts make sense.

For example i decided against using a sympfony serializer wrapper for the normalizers, as its not configurable via objects yaml.
In the end this is a nice refactoring to centralise the serialisation to happen at one place (not RuntimeContentCache AND ContentCache)

[Sebobo]

Fine by reading with my limited understanding of this specific topic.

[kitsunet]

Seems fine I guess, bit weird that the serializer creates an array but I guess that's legacy from how it was before

[mhsdesign]

creates an array

actually thats new :D As the content cache doesnt care as long as its json serialise able i decided for array.
And this is just an intermediate step, with #4868 we can use the NodeIdentity dto here :D

Thats how the symfony denormaliser thing is allowed to work.