TASK: Add test for nodeType property unset behaviour #4620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 15, 2023
mhsdesign
commented
Oct 16, 2023
Comment on lines
+408
to
+424
| 'Neos.ContentRepository.Testing:Sub' => [ | ||
| 'superTypes' => ['Neos.ContentRepository.Testing:Base' => true], | ||
| 'properties' => [ | ||
| // Pseudo unset. | ||
| // The property will still be existent but looses its type information (falls back to string). | ||
| // Also, the property will not show up anymore in the ui as the inspector configuration is gone as well. | ||
| 'foo' => [] | ||
| ] | ||
| ] |
There was a problem hiding this comment.
we should discuss at some point if we like this kinda stuff
There was a problem hiding this comment.
Do we have an issue where this can be discussed?
There was a problem hiding this comment.
here? ^^ or ill ask in slack ...
slack: https://neos-project.slack.com/archives/C3MCBK6S2/p1697705743160529
6 tasks
ahaeslich
approved these changes
Oct 19, 2023
kitsunet
approved these changes
Oct 19, 2023
mhsdesign
force-pushed
the
task/addTestForNodeTypePropertyUnsetBehaviour
branch
from
904f93a to
05c8150
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
just to document the current state (it has been like this since neos 7 and 8 too).
In #4618 we discuss wether we like to keep it this way.