Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEATURE: NodeType allow unsetting inherited properties #4618

Closed
wants to merge 1 commit into from

Conversation

mhsdesign
Copy link
Member

This will make it possible to adjust #4563 (comment). We want to unset the uriPathSegment of the Site:

'Neos.Neos:Site':
  properties:
    uriPathSegment: ~

Upgrade instructions

Review instructions

Checklist

  • Code follows the PSR-2 coding style
  • Tests have been created, run and adjusted as needed
  • The PR is created against the lowest maintained branch
  • Reviewer - PR Title is brief but complete and starts with FEATURE|TASK|BUGFIX
  • Reviewer - The first section explains the change briefly for change-logs
  • Reviewer - Breaking Changes are marked with !!! and have upgrade-instructions

@kitsunet
Copy link
Member

I am not a fan, as said on Slack, I think if something proclaims to be isOfType($nodeTypeName) one should also be able to expect the set of properties from said $nodeTypeName

@mhsdesign mhsdesign force-pushed the feature/nodeTypeUnsetInheritedProperties branch from f016f45 to e204c51 Compare October 15, 2023 09:08
@mhsdesign mhsdesign force-pushed the feature/nodeTypeUnsetInheritedProperties branch from e204c51 to f6a60f3 Compare October 15, 2023 09:11
@mhsdesign
Copy link
Member Author

I understand and totally agree. It already seems odd that one can change the type of a property (we maybe should disallow this already).

Those are the tests for the current behavior: #4620

It seems there were none before.

@mhsdesign
Copy link
Member Author

We rather want to go the way of being more strict regarding this case #4722

@mhsdesign mhsdesign closed this Nov 11, 2023
@mhsdesign mhsdesign deleted the feature/nodeTypeUnsetInheritedProperties branch November 12, 2023 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants