BUGFIX: Remove Neos WorkspaceName
#4534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
mhsdesign
reviewed
Sep 19, 2023
|
❤️ |
mhsdesign
approved these changes
Sep 19, 2023
There was a problem hiding this comment.
Thanks for taking care, i think we need to adjust the neos ui too.
Ahh i see you did this here : neos/neos-ui#3624 ❤️
|
Since we removed the odd logic, i think we can remove also this |
6 tasks
|
So i ran the neos-ui e2e tests (with neos/neos-ui#3624) locally and everything seems to work so i would like to merge this task :D |
ahaeslich
reviewed
Sep 28, 2023
bwaidelich
commented
Sep 28, 2023
9 tasks
ahaeslich
approved these changes
Sep 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #4533
Neos ui part neos/neos-ui#3624