Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TASK: Deprecate legacy User Utility #4530

Merged
merged 2 commits into from
Sep 28, 2023
Merged

Conversation

mhsdesign
Copy link
Member

Lets deprecate the legacy User utility. The helper contained minimal logic, which is now mostly moved to NeosWorkspaceName

Removing or renaming the UserUtility might be a little unwise, as its also used in the Neos.Demo!

resolves partially #4341

Upgrade instructions

Review instructions

Checklist

  • Code follows the PSR-2 coding style
  • Tests have been created, run and adjusted as needed
  • The PR is created against the lowest maintained branch
  • Reviewer - PR Title is brief but complete and starts with FEATURE|TASK|BUGFIX
  • Reviewer - The first section explains the change briefly for change-logs
  • Reviewer - Breaking Changes are marked with !!! and have upgrade-instructions

Copy link
Member

@bwaidelich bwaidelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

blocked by #4529 – I'll update once I'm done with the other

Copy link
Member

@bwaidelich bwaidelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, depending on #4534

@mhsdesign mhsdesign merged commit df94457 into 9.0 Sep 28, 2023
5 checks passed
@mhsdesign mhsdesign deleted the task/deprecateUserUtility branch September 28, 2023 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants