Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEATURE: Overhaul command constructors #4489

Merged
merged 7 commits into from
Sep 14, 2023

Conversation

bwaidelich
Copy link
Member

@bwaidelich bwaidelich commented Sep 8, 2023

Add a named create constructor to all commands, add doc comments and remove internal arguments
from the default constructor in favor of dedicated with*() methods

Related: #4375
Related: #4487

@github-actions github-actions bot added the 9.0 label Sep 8, 2023
@bwaidelich bwaidelich marked this pull request as ready for review September 8, 2023 18:17
@bwaidelich
Copy link
Member Author

NOTE: Requires neos/neos-ui#3612 to be merged, too!

@bwaidelich bwaidelich changed the title WIP: FEATURE: Overhaul command constructors FEATURE: Overhaul command constructors Sep 8, 2023
@crydotsnake crydotsnake added the Neos.Ui Neos Ui topics, that depend also on Neos adjustments label Sep 8, 2023
Copy link
Member

@mhsdesign mhsdesign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did look thought the changes. At first more carefully but later a little less ^^ Fine by reading.

Copy link
Member

@kitsunet kitsunet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot, this looks super nice!

@bwaidelich bwaidelich merged commit 020a0e0 into 9.0 Sep 14, 2023
5 checks passed
@bwaidelich bwaidelich deleted the feature/4375-overhaul-command-constructors branch September 14, 2023 14:12
ahaeslich added a commit to queoGmbH/Sitegeist.Taxonomy that referenced this pull request Sep 17, 2023
mhsdesign added a commit that referenced this pull request Oct 25, 2023
mhsdesign added a commit that referenced this pull request Oct 26, 2023
…For4489

TASK: Command constructor followup to #4489
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
9.0 Feature Neos.Ui Neos Ui topics, that depend also on Neos adjustments
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants