Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TASK: Command constructor followup to #4489 #4646

Merged
merged 1 commit into from
Oct 26, 2023
Merged

TASK: Command constructor followup to #4489 #4646

merged 1 commit into from
Oct 26, 2023

Conversation

mhsdesign
Copy link
Member

Followup to #4489

Upgrade instructions

Review instructions

Checklist

  • Code follows the PSR-2 coding style
  • Tests have been created, run and adjusted as needed
  • The PR is created against the lowest maintained branch
  • Reviewer - PR Title is brief but complete and starts with FEATURE|TASK|BUGFIX
  • Reviewer - The first section explains the change briefly for change-logs
  • Reviewer - Breaking Changes are marked with !!! and have upgrade-instructions

@mhsdesign mhsdesign added the 9.0 label Oct 25, 2023
@github-actions github-actions bot added the Task label Oct 25, 2023
mhsdesign added a commit to neos/neos-ui that referenced this pull request Oct 25, 2023
@mhsdesign
TASK: Adjust SetNodeReferences to use static create factory
f9ceb17 
Neos change neos/neos-development-collection#4646
@mhsdesign mhsdesign requested a review from bwaidelich October 25, 2023 17:56
bwaidelich
bwaidelich approved these changes Oct 25, 2023
View reviewed changes
Copy link
Member

@bwaidelich bwaidelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I must have missed those

@mhsdesign mhsdesign merged commit f61829f into 9.0 Oct 26, 2023
5 checks passed
@mhsdesign mhsdesign deleted the task/commandConstructorAdjustmentsFor4489 branch October 26, 2023 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bwaidelich bwaidelich bwaidelich approved these changes

Assignees
No one assigned
Labels
9.0 Task
Projects
Neos 9.0 Release Board
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mhsdesign @bwaidelich