another sync of changes from my other repo #171
Conversation
cooljeanius
commented
Jan 27, 2024
•
cooljeanius
commented
- create CODEOWNERS file, to ensure that the primary people who have edited files get notified when changes to them are proposed (I'm the only one in it so far, as anyone else who it'd make sense to add would have to be added as a collaborator to this repo first)
- enable optional advancements; closes Enable optional advancements? #118
- confirmation of @alxrem's translation credits entry
- start on ChangeLog entries for next release (which will be 1.7.0)
- updated Medic frankenportrait from @DuncanusDillius
- even more validator fixes that I had thought were too difficult to do previously
- start writing support conversations (in macros/conversations_support.cfg), for issue FE-style support conversations #73
- improve S01 cutscene/dialogue
- attempt at debugging odd bug where Lorin randomly disappears when visiting the gallows in S02
- minor updates to the Akladian name generator
- create CODEOWNERS file - enable optional advancements as per issue nemaara#118 - confirmation of @alxrem's translation credits entry - start on ChangeLog - updated Medic frankenportrait from @DuncanusDillius - even more validator fixes that I thought were too difficult to do previously - start writing support conversations - improve S01 cutscene/dialogue - attempt at debugging odd bug where Lorin randomly disappears when visiting the gallows in S02 - minor updates to the Akladian name generator
|
@nemaara any thoughts? |
|
it's 1000 lines so lemme comment tmrw or sth |
all of a sudden I've gotten all self-conscious about the support convos... feel free to tell me to leave those out if they make things too difficult to review... |
remove unused Karen x Yahyazad S-rank convo (I'd already ifdef-ed it out, anyways)
...ok, I trimmed them down a bit by removing one of them... |
regenerate with `wmlxgettext` to reflect removal of unused conversation
|
ok I got it down under 1000 lines with 481329d (most of the lines are in the potfile) |
|
I think some of the text could use revising but I don't have time to do that right now. I could add it in as is or would you like to try a second time at rewriting some lines? Basically I'm not sure some of the characters' personalities were captured in the newer text. |
I mean, I guess another thing I could do would be to split the support convos off into a separate PR? Does everything else besides the support convos look fine? |
Co-authored-by: nemaara <[email protected]>
Add additional comment to address point raised in PR
Updates from review of nemaara/A_New_Order#171
