Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable optional advancements? #118

Closed
cooljeanius opened this issue Mar 5, 2023 · 5 comments · Fixed by #171
Closed

Enable optional advancements? #118

cooljeanius opened this issue Mar 5, 2023 · 5 comments · Fixed by #171
Labels
question Further information is requested
Milestone

Comments

@cooljeanius
Copy link
Collaborator

Mainline's optional_unit_advancements.cfg contains a bunch of optional advancements that we could enable: https://www.wesnoth.org/macro-reference.html#file:optional_unit_advancements.cfg

Friendly ones:

Hostile ones:

So, what do people think? Does it make sense to enable any of these? Perhaps only on certain difficulty levels?

@cooljeanius cooljeanius added the question Further information is requested label Mar 5, 2023
@cooljeanius
Copy link
Collaborator Author

@Toranks @nemaara any opinions?

@nemaara
Copy link
Owner

nemaara commented Apr 8, 2023

For me, it's not necessary to enable any but I leave it to you.

@Toranks
Copy link
Contributor

Toranks commented Apr 8, 2023

It doesn't hurt, but I think the campaign is not long enough to enjoy those advances

@cooljeanius cooljeanius added this to the 1.7.0 milestone Jun 27, 2023
@cooljeanius
Copy link
Collaborator Author

ok I think I'll try enabling them for 1.7.0, just to see how that goes...

cooljeanius added a commit to cooljeanius/A_New_Order that referenced this issue Jan 1, 2024
see nemaara/A_New_Order#118
also continue writing some support conversations
cooljeanius added a commit to cooljeanius/A_New_Order-1 that referenced this issue Jan 16, 2024
- create CODEOWNERS file
- enable optional advancements as per issue nemaara#118
- confirmation of @alxrem's translation credits entry
- start on ChangeLog
- updated Medic frankenportrait from @DuncanusDillius
- even more validator fixes that I thought were too difficult to do previously
- start writing support conversations
- improve S01 cutscene/dialogue
- attempt at debugging odd bug where Lorin randomly disappears when visiting the gallows in S02
- minor updates to the Akladian name generator
@cooljeanius
Copy link
Collaborator Author

PR #171 will close this.

cooljeanius added a commit that referenced this issue Apr 2, 2024
another sync of changes from my other repo:
- create CODEOWNERS file, to ensure that the primary people who have edited files get notified when changes to them are proposed (I'm the only one in it so far, as anyone else who it'd make sense to add would have to be added as a collaborator to this repo first)
- enable optional advancements; closes #118
- confirmation of @alxrem's translation credits entry
- start on ChangeLog entries for next release (which will be 1.7.0)
- updated Medic frankenportrait from @DuncanusDillius
- even more validator fixes that I had thought were too difficult to do previously
- start writing support conversations (in macros/conversations_support.cfg), for issue #73 (will probably be rewritten)
- improve S01 cutscene/dialogue
- attempt at debugging odd bug where Lorin randomly disappears when visiting the gallows in S02
- minor updates to the Akladian name generator
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants