feat: symfony 7 support

[faizanakram99]

• makes doctrine/annotations optional
• updates tests and ci to test with both symfony 7 and < symfony 7 version
• adds routes-attributes.yaml file for symfony 7 compatible controllers/routes
• updates some fixtures to use attributes when sf7 kernel is installed
• skips tests/packages related to packages like jms serializer, bazinga, etc not supported by symfony 7 for symfony 7 matrix

Fixes #2143 and #2147, supersedes #2151 and #2155

#SymfonyHackday

[faizanakram99]

Tests are failing with this error, i am not sure why

Multiple @OA\Response() with the same response="200":
  \Nelmio\ApiDocBundle\Tests\Functional\Controller\InvokableController->__invoke() in path/to/NelmioApiDocBundle/Tests/Functional/Controller/InvokableController.php

  \Nelmio\ApiDocBundle\Tests\Functional\Controller\SerializedNameController->serializedNameAction() in path/to/NelmioApiDocBundle/Tests/Functional/Controller/SerializedNameController.php" at DefaultLogger.php line 31

[faizanakram99]

Ok from the looks of it, i don't think it will be possible to support both sf 7 and previous versions, sf 7 conflicts with sensio framework extra and it is probably required for all previous sf versions.

Looks like we need a major version bump and drop all those packages altogether.

nvm

[DjordyKoert]

Thanks a lot :)

[RobertMe]

I find it quite rude to use mine (and @DjordyKoert) our changes and commit them under your own name. Especially since at least my PR is waiting for review, and not because I abondended it (/not because didn't incorperate requested changes).

Your could have just merged both branches / pull requests into your own branch so it would be clear that someone else wrote the code, and add your own changes on top of it.

[faizanakram99]

I find it quite rude to use mine (and @DjordyKoert) our changes and commit them under your own name. Especially since at least my PR is waiting for review, and not because I abondended it (/not because didn't incorperate requested changes).

Your could have just merged both branches / pull requests into your own branch so it would be clear that someone else wrote the code, and add your own changes on top of it.

apologies, i did mention it in a comment that I missed that there was a PR #2151 (comment)

Later I tried to fork your repositories so that I add my changes on top of it but since I had already made all the changes locally (including both making doctrine/annotations optional and adding sf 7 support), i found it hard to separate them and apply on top of your changes. If you wish, I can give you write permissions to this repository (actually you and @DjordyKoert both), so that you may re-add your commits or even ammend existing commits.

It doesn't really matter to me whom the commits are attributed to, I want support for sf7 in this lib because we are using it and it is blocking our sf 7 upgrade and it seemed a good task for symfony hack day. Again apology for any miscommunications @RobertMe

[DjordyKoert]

I find it quite rude to use mine (and @DjordyKoert) our changes and commit them under your own name. Especially since at least my PR is waiting for review, and not because I abondended it (/not because didn't incorperate requested changes).

Your could have just merged both branches / pull requests into your own branch so it would be clear that someone else wrote the code, and add your own changes on top of it.

I personally have no issue with my 'changes'/commits being lost, since my PR contained the bare minimum (and didn't even work to begin with). I am just very happy @faizanakram99 was able to make it (almost? because CI is still failing) work for Symfony 7. 😄

[DjordyKoert]

Tests are failing with this error, i am not sure why

Multiple @OA\Response() with the same response="200":
  \Nelmio\ApiDocBundle\Tests\Functional\Controller\InvokableController->__invoke() in path/to/NelmioApiDocBundle/Tests/Functional/Controller/InvokableController.php

  \Nelmio\ApiDocBundle\Tests\Functional\Controller\SerializedNameController->serializedNameAction() in path/to/NelmioApiDocBundle/Tests/Functional/Controller/SerializedNameController.php" at DefaultLogger.php line 31

I can also reproduce this locally. This is a very weird one since it's appending the response from InvokableController to the SerializedNameController /api/serializename path?????

[DjordyKoert]

@faizanakram99 I have created a PR on your fork repo with changes to make phpunit work for Symfony 7. https://github.com/faizanakram99/NelmioApiDocBundle/pull/1

Older versions are still failing but this should be a good starting point for fixing the others 😄

[faizanakram99]

@faizanakram99 I have created a PR on your fork repo with changes to make phpunit work for Symfony 7. faizanakram99#1

Older versions are still failing but this should be a good starting point for fixing the others 😄

Thank you so much @DjordyKoert , I've merged your changes (with rebase)

I think you also need to run cs-fix on changed files, style ci is complaining

[DjordyKoert]

@faizanakram99 could you please run a style fix 😄, mine doesn't really fix anything for some reason

[DjordyKoert]

@faizanakram99 could you please run a style fix 😄, mine doesn't really fix anything for some reason

Nevermind that, I simply applied the diff from styleci https://github.com/faizanakram99/NelmioApiDocBundle/pull/3 😃

@faizanakram99 a merge and styleci should be fixed

[DjordyKoert]

@GuilhemN any possibility you can look at this? ❤️

[Gemorroj]

@GuilhemN ping

[GuilhemN]

Thank you very much for the huge work!
I will try to look into fixing the CI a bit later.

Happy new year, best wishes!

[DjordyKoert]

Thank you very much @GuilhemN !

Happy new years & best wishes to you too ❤️