Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Support for Symfony 7 #2151

Closed
wants to merge 3 commits into from

Conversation

DjordyKoert
Copy link
Collaborator

Update NelmioApiDocBundle to support Symfony 7.

Related issues: #2147 #2143

Comment on lines +92 to +93
},
"minimum-stability": "beta"
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove minimum-stability flag on Symfony 7 release

Suggested change
},
"minimum-stability": "beta"
}

"zircote/swagger-php": "^4.2.15",
"phpdocumentor/reflection-docblock": "^3.1|^4.0|^5.0"
},
"require-dev": {
"sensio/framework-extra-bundle": "^5.4|^6.0",
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sensio/framework-extra-bundle had to be removed because it is archived and will not be updated for Symfony 7

@abramchikd
Copy link

abramchikd commented Dec 6, 2023

Hey! Is this PR still alive?
I can help if needed

@DjordyKoert
Copy link
Collaborator Author

I will try and update this PR some time soon. Probably gonna base it on #2155 since it already contains all of the changes needed to make Doctrine Annotations work.

@DjordyKoert
Copy link
Collaborator Author

DjordyKoert commented Dec 8, 2023

@abramchikd any help would be appreciated, I just cannot figure out how to fix our unit tests. Almost all of them keep failing because all Symfony attributes are no longer an annotation which causes Doctrine's DocParser to throw an exception. Adding the @IgnoreAnnotation("Regex") annotation in this example does not seem to work either.

46) Nelmio\ApiDocBundle\Tests\Functional\FunctionalTest::testPrivateProtectedExposure
Doctrine\Common\Annotations\AnnotationException: [Semantical Error] The class "Symfony\Component\Validator\Constraints\Regex" is not annotated with @Annotation.
Are you sure this class can be used as annotation?
If so, then you need to add @Annotation to the _class_ doc comment of "Symfony\Component\Validator\Constraints\Regex".
If it is indeed no annotation, then you need to add @IgnoreAnnotation("Regex") to the _class_ doc comment of method Nelmio\ApiDocBundle\Tests\Functional\Controller\FOSRestController80::fosrestAction().

dfridrich added a commit to dfridrich/NelmioApiDocBundle that referenced this pull request Dec 9, 2023
@faizanakram99
Copy link
Contributor

@DjordyKoert i made another attempt for symfony 7 support, you may have a look #2164 but from the looks of it, it incorporates changes from #2155 (i totally missed that there was a PR when i started working on this last Saturday at Symfony hack day)

@DjordyKoert
Copy link
Collaborator Author

See #2164 instead

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants