fixed Level on MoreBottomSheetFragment

neeldoshii · Dec 1, 2024 · 871c0ff · 871c0ff
1 parent 293cbeb
commit 871c0ff
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 4 deletions.
diff --git a/app/src/main/java/fr/free/nrw/commons/navtab/MoreBottomSheetFragment.kt b/app/src/main/java/fr/free/nrw/commons/navtab/MoreBottomSheetFragment.kt
@@ -111,10 +111,18 @@ class MoreBottomSheetFragment : BottomSheetDialogFragment() {
     private fun setUserName() {
         val store = BasicKvStore(requireContext(), getUserName())
         val level = store.getString("userAchievementsLevel", "0")
-        binding?.moreProfile?.text = if (level == "0") {
-            "${getUserName()} (${getString(R.string.see_your_achievements)})"
+        if (level == "0"){
+            binding?.moreProfile?.text = getString(
+                R.string.profileLevel,
+                getUserName(),
+                getString(R.string.see_your_achievements) // Second argument
+            )
         } else {
-            "${getUserName()} (${getString(R.string.level)} $level)"
+            binding?.moreProfile?.text = getString(
+                R.string.profileLevel,
+                getUserName(),
+                level
+            )
         }
     }
 

diff --git a/app/src/main/java/fr/free/nrw/commons/profile/achievements/AchievementsFragment.kt b/app/src/main/java/fr/free/nrw/commons/profile/achievements/AchievementsFragment.kt
@@ -369,7 +369,7 @@ class AchievementsFragment : CommonsDaggerSupportFragment(){
             )
         )
         binding.achievementBadgeText.text = levelInfo.levelNumber.toString()
-        val store = BasicKvStore(this.context, userName)
+        val store = BasicKvStore(requireContext(), userName)
         store.putString("userAchievementsLevel", levelInfo.levelNumber.toString())
     }
 

diff --git a/app/src/main/res/values/strings.xml b/app/src/main/res/values/strings.xml
@@ -376,6 +376,7 @@
   <string name="statistics_featured">Featured Images</string>
   <string name="statistics_wikidata_edits">Images via \"Nearby Places\"</string>
   <string name="level">Level %d</string>
+  <string name="profileLevel">%s (Level %s)</string>
   <string name="images_uploaded">Images Uploaded</string>
   <string name="image_reverts">Images Not Reverted</string>
   <string name="images_used_by_wiki">Images Used</string>