fixed AchievementFragment Unit Test

neeldoshii · Dec 1, 2024 · 293cbeb · 293cbeb
1 parent ba54e01
commit 293cbeb
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 8 deletions.
diff --git a/app/src/main/java/fr/free/nrw/commons/profile/achievements/AchievementsFragment.kt b/app/src/main/java/fr/free/nrw/commons/profile/achievements/AchievementsFragment.kt
@@ -136,7 +136,7 @@ class AchievementsFragment : CommonsDaggerSupportFragment(){
     /**
      * To invoke the AlertDialog on clicking info button
      */
-    protected fun showInfoDialog() {
+    fun showInfoDialog() {
         launchAlert(
             resources.getString(R.string.Achievements),
             resources.getString(R.string.achievements_info_message)
@@ -391,47 +391,47 @@ class AchievementsFragment : CommonsDaggerSupportFragment(){
         }
     }
 
-    protected fun showUploadInfo() {
+    fun showUploadInfo() {
         launchAlertWithHelpLink(
             resources.getString(R.string.images_uploaded),
             resources.getString(R.string.images_uploaded_explanation),
             IMAGES_UPLOADED_URL
         )
     }
 
-    protected fun showRevertedInfo() {
+    fun showRevertedInfo() {
         launchAlertWithHelpLink(
             resources.getString(R.string.image_reverts),
             resources.getString(R.string.images_reverted_explanation),
             IMAGES_REVERT_URL
         )
     }
 
-    protected fun showUsedByWikiInfo() {
+    fun showUsedByWikiInfo() {
         launchAlertWithHelpLink(
             resources.getString(R.string.images_used_by_wiki),
             resources.getString(R.string.images_used_explanation),
             IMAGES_USED_URL
         )
     }
 
-    protected fun showImagesViaNearbyInfo() {
+    fun showImagesViaNearbyInfo() {
         launchAlertWithHelpLink(
             resources.getString(R.string.statistics_wikidata_edits),
             resources.getString(R.string.images_via_nearby_explanation),
             IMAGES_NEARBY_PLACES_URL
         )
     }
 
-    protected fun showFeaturedImagesInfo() {
+    fun showFeaturedImagesInfo() {
         launchAlertWithHelpLink(
             resources.getString(R.string.statistics_featured),
             resources.getString(R.string.images_featured_explanation),
             IMAGES_FEATURED_URL
         )
     }
 
-    protected fun showThanksReceivedInfo() {
+    fun showThanksReceivedInfo() {
         launchAlertWithHelpLink(
             resources.getString(R.string.statistics_thanks),
             resources.getString(R.string.thanks_received_explanation),

diff --git a/...src/test/kotlin/fr/free/nrw/commons/profile/achievements/AchievementsFragmentUnitTests.kt b/...src/test/kotlin/fr/free/nrw/commons/profile/achievements/AchievementsFragmentUnitTests.kt
@@ -79,7 +79,7 @@ class AchievementsFragmentUnitTests {
         fragmentTransaction.commitNowAllowingStateLoss()
 
         layoutInflater = LayoutInflater.from(activity)
-        view = fragment.onCreateView(layoutInflater, activity.findViewById(R.id.container), null)!!
+        view = fragment.onCreateView(layoutInflater, activity.findViewById(R.id.container), null)
 
         achievements = Achievements(0, 0, 0, 0, 0, 0, 0)
     }