Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix game crash from localization #47

Open
wants to merge 31 commits into
base: master
Choose a base branch
from

Conversation

Galandrielle
Copy link

@Galandrielle Galandrielle commented Jun 21, 2022

The game is crashing with this error:

Error: Scene_Preloader.js:49 Uncaught ReferenceError: textStrings is not defined

This pull request will fix the game crash in localization so that the Greek translation can be added.

@Galandrielle Galandrielle mentioned this pull request Jun 21, 2022
@Galandrielle Galandrielle reopened this Jun 21, 2022
Copy link
Contributor

@natan-dias natan-dias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good for me.


var textStrings = textStrings_FA
//var textStrings = textStrings_KR;
const textStrings = (() => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good code. I will add that to my fork, while we don't have this PR approved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants