Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Greek Translation #31

Open
Galandrielle opened this issue Jan 3, 2021 · 10 comments
Open

Greek Translation #31

Galandrielle opened this issue Jan 3, 2021 · 10 comments

Comments

@Galandrielle
Copy link

Galandrielle commented Jan 3, 2021

Hello and Happy New Year, @ncase ! So, I decided to translate this game in Greek and after attempts, I finally connected it to this link: https://galandrielle.github.io/wbwwb/

I have changed the files textStrings.js and index.html so far at my repository. However, the game is still a black screen and only has the pause text when I click away. These two are the only files I've touched. Did I write the code somewhere wrong? Do I need to modify the other files too? Any help by anyone will be good.

@WillYuum
Copy link

@Galandrielle

I have checked the game and it is crashing, I did a fix but I gotta wait for it to be accepted but you can check the fix I made so you can simply follow the fix steps I made here:

Issue Fix: #44

@Galandrielle
Copy link
Author

@WillYuum Okay, I added the code you put there (const textStrings), what do I do next? Do I ask for a pull request?

@WillYuum
Copy link

@Galandrielle
So yeah the next process after adding and testing your changes is to do a pull request so your changes can go to Master branch

You can watch this fast tutorial of how to do it Pull Request Video
Note: The video is a bit fast but take your time with it because the info provided is good enough for anyone trying to achieve a pull request.

@Galandrielle
Copy link
Author

@WillYuum I think I did it, is this correct?
#47

@WillYuum
Copy link

@Galandrielle
Okay so great progress but you did some stuff that aren't necessary like:

  • Removing all the text from the README.md file, that file is made by the creator to share important information like where she got the assets and that the project is open source.
  • You edited the index.html file which you shouldn't do at all, the game should handle showing you the proper text from the textString.js but the game has an issue in that.

The game has an issue in the pre-loader scene and is only displaying the Persian language which shouldn't happen. I will try to see what's the issue

What you should do is just add your translation to textString.js and with js code that I gave you so you can run the game.

@Galandrielle
Copy link
Author

@WillYuum Thank you so much for the tips so far! How about now? If this is correct, what shall I do next?
#47

@WillYuum
Copy link

So actually just for the sake of being neat, try to make your changes just show what you added
You can see in the link you shared that it looks like you added everything in textString.js, the green part should just show what you actually added and you still have changes in index.html and I don't why

Oh one more thing you should do so the game can know that you added the language

Add this to last part of the code after line 737, just copy paste it :)

case "es":
	return textStrings_GR;

@Galandrielle
Copy link
Author

@WillYuum Done! Now it will show the changes I did, which include adding Greek as a language.

@WillYuum
Copy link

WillYuum commented Jun 21, 2022

@Galandrielle Great, only thing we can do now is wait for the epic developer to read the changes if she'll ever.
But be proud you have contributed to a beautiful game :D

@Galandrielle
Copy link
Author

@WillYuum Fingers crossed! Thank you so much for your help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants