(feat) Adding Chaos Engineering #136
Conversation
|
Hey @natenho, mind taking a look at this PR please? |
| { | ||
| httpResponse.StatusCode = (int)HttpStatusCode.InternalServerError; | ||
|
|
||
| var bodyBytes = Encoding.UTF8.GetBytes($"Error {httpResponse.StatusCode}: {HttpStatusCode.ServiceUnavailable}"); |
There was a problem hiding this comment.
The status code in the string is ServiceUnavailable, I suppose you mean InternalServerError, right?
|
|
||
| private static IServiceCollection AddChaosServices(this IServiceCollection services) => | ||
| services | ||
| .AddSingleton<IChaosStrategy, ChaosStrategyBehavior>() |
There was a problem hiding this comment.
Do we really need singletons here? I would make any dependency as transient by default if I dont need a singleton..it is much easier to deal with concurrent requests in transient objects if we need some context inside the behavior
There was a problem hiding this comment.
@lanegoolsby there you go! The code is very good, just some minor issues, we can merge it asap if you could please review the pr comments! :)
|
@lanegoolsby I took the liberty of making the changes to avoid taking even more time to do the merge. Thank you for your contribution! |
|
Thank you!! |
This is a direct copy of #114, I just addressed the PR feedback. I have a need for this feature and that other PR stalled. :)