Add Chaos Engineering to inject random crashes into calls #114
Conversation
There was a problem hiding this comment.
Hello @fernandobianchini, I've added some comments to the PR for your consideration.
Thank you for your contribution!!
There was a problem hiding this comment.
What do you think of the "IChaosStrategy" name? It sounds better to me.
|
|
||
| var bodyBytes = Encoding.UTF8.GetBytes($"Error {httpResponse.StatusCode}: {HttpStatusCode.ServiceUnavailable}"); | ||
|
|
||
| await httpResponse.Body.WriteAsync(bodyBytes, 0, bodyBytes.Length, default); |
There was a problem hiding this comment.
The await is not necessary here, you can directly return the task
|
|
||
| var bodyBytes = Encoding.UTF8.GetBytes($"Error {httpResponse.StatusCode}: {HttpStatusCode.InternalServerError}"); | ||
|
|
||
| await httpResponse.Body.WriteAsync(bodyBytes, 0, bodyBytes.Length, default); |
There was a problem hiding this comment.
The await is not necessary here, you can directly return the task
| { | ||
| var responseDelay = new Random().Next(_options.Value.MinimumLatencyTime, _options.Value.MaximumLatencyTime); | ||
| _logger.LogInformation($"Chaos Latency (ms): {responseDelay}"); | ||
| await Task.Delay(responseDelay); |
There was a problem hiding this comment.
The await is not necessary here, you can directly return the task
|
|
||
| var bodyBytes = Encoding.UTF8.GetBytes($"Error {httpResponse.StatusCode}: {HttpStatusCode.BadRequest}"); | ||
|
|
||
| await httpResponse.Body.WriteAsync(bodyBytes, 0, bodyBytes.Length, default); |
There was a problem hiding this comment.
The await is not necessary here, you can directly return the task
|
|
||
| } | ||
|
|
||
| await _next(httpContext); |
There was a problem hiding this comment.
The await is not necessary here, you can directly return the task :)
|
|
||
| public async Task Invoke(HttpContext httpContext) | ||
| { | ||
| if (_options.Value.Enabled) |
There was a problem hiding this comment.
Inverting this if would reduce the nesting
| "profiles": { | ||
| "Mockaco": { | ||
| "commandName": "Project", | ||
| "launchBrowser": true, | ||
| "launchUrl": "hello/fernando", |
There was a problem hiding this comment.
Please remove this specific launch settings
|
This PR has been stalled and I'm closing it in favor of #136 |
No description provided.