Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use codecov v4, single upload step, and non-codecov reports #14

Merged
merged 11 commits into from
Jun 4, 2024

Conversation

Czaki
Copy link
Contributor

@Czaki Czaki commented Jun 3, 2024

This PR solves #13 (comment) and moves coverage upload to a separate step to make the CI logs cleaner.

It also adds support for GHA-only coverage reports using the method from
hynek.me/articles/ditch-codecov-python

@jni
Copy link
Member

jni commented Jun 3, 2024

Nice! Thanks @Czaki! However it is currently failing in a weird way. 😅

@jni jni changed the title Use codecov v4 and single upload steep Use codecov v4 and single upload step Jun 3, 2024
@Czaki
Copy link
Contributor Author

Czaki commented Jun 3, 2024

Nice! Thanks @Czaki! However it is currently failing in a weird way. 😅

It is not verid. I hit this every time I migrate to this schema. it is only problem with paths between operating systems...

Copy link

codecov bot commented Jun 3, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 75.27%. Comparing base (ff1b148) to head (3c4606b).

Files Patch % Lines
src/napari_graph/base_graph.py 0.00% 1 Missing ⚠️
src/napari_graph/directed_graph.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #14      +/-   ##
==========================================
- Coverage   80.40%   75.27%   -5.13%     
==========================================
  Files           6        6              
  Lines         546      546              
  Branches       95      121      +26     
==========================================
- Hits          439      411      -28     
  Misses         73       73              
- Partials       34       62      +28     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Czaki
Copy link
Contributor Author

Czaki commented Jun 3, 2024

@jni it is ready to review.
Also contains hynek.me/articles/ditch-codecov-python

obraz

It looks like branch coverage is handled differently on codecov.io and normal report.

@Czaki Czaki requested a review from jni June 4, 2024 08:04
@jni jni changed the title Use codecov v4 and single upload step Use codecov v4, single upload step, and non-codecov reports Jun 4, 2024
@jni jni merged commit 71f544d into napari:main Jun 4, 2024
19 of 21 checks passed
@jni
Copy link
Member

jni commented Jun 4, 2024

Amazing! Thank you @Czaki!

@Czaki Czaki deleted the modernize_coverage branch June 4, 2024 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants