Update from macos-11 to macos-13 on github actions #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Something is wrong with uploading to codecov, see the failing CI logs. I don't have the right permissions to this repo or on codecov to investigate the failure. |
|
I don't have it either, can you check this @jni ? |
|
I actually don't know what I'm supposed to do here. We never had codecov keys in this repo, it seems. I'm inclined to just remove the codecov step and then make an issue to add this approach to the repo: |
|
Problem comes from using codecov v3 instead of v4 in workflow. |
jni
pushed a commit
that referenced
this pull request
Jun 4, 2024
This PR solves #13 (comment) and moves coverage upload to a separate step to make the CI logs cleaner. It also adds support for GHA-only coverage reports using the method from [hynek.me/articles/ditch-codecov-python](https://hynek.me/articles/ditch-codecov-python/)
|
Merged in main, let's see how this goes... 🤞 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #13 +/- ##
=======================================
Coverage 75.27% 75.27%
=======================================
Files 6 6
Lines 546 546
Branches 121 121
=======================================
Hits 411 411
Misses 73 73
Partials 62 62 ☔ View full report in Codecov by Sentry. |
|
Whoop whoop! 😊 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Github Actions macos-11 runner will be deprecated soon, upgrade to macos-13 in
tox.ini.Related to zulip discussion: https://napari.zulipchat.com/#narrow/stream/212875-general/topic/macos-11.20runners.20deprecation