Models required for a Configurable DSP with Parametric Equalizer #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 26, 2024
maximmaxim345
force-pushed
the
feat/dsp
branch
from
aeb95d1 to
d8a9378
Compare
|
The linter found a few small formatting issues, can you fix those ? Otherwise looks good! |
maximmaxim345
force-pushed
the
feat/dsp
branch
from
d8a9378 to
fcdf6ae
Compare
|
Fixed them, can you try again now? |
This commit adds `DSPConfig`, which describes a multi step DSP pipeline for a player. For now only `ParametricEQFilter` is added, but future work could expand the filter selection to include convolutional, graphical EQ, limiting and compression filters.
This adds a TONE_CONTROL DSP Filter, replacing the old CONF_EQ_BASS, CONF_EQ_MID and CONF_EQ_TREBLE options.
marcelveldt
force-pushed
the
feat/dsp
branch
from
1468a83 to
ce7e5eb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds models as required by music-assistant/server#1795, see that PR for a full description.
Related Changes
This PR is to be viewed in conjunction with music-assistant/frontend#756 and music-assistant/server#1795.