Add UI for Configuring DSP including Parametric Equalizers #756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 26, 2024
maximmaxim345
force-pushed
the
feat/dsp
branch
3 times, most recently
from
ccba517 to
e4105b8
Compare
This commit adds a graphical editor for configuring the DSP Pipeline of a Player with support for a Parametric Equalizer.
This is a simple 3 band equalizer that replaces the old CONF_EQ_BASS, CONF_EQ_MID and CONF_EQ_TREBLE options.
maximmaxim345
force-pushed
the
feat/dsp
branch
from
8a12a77 to
c9aa175
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This Pull Request introduces a sophisticated multi-stage Digital Signal Processing (DSP) system to Music Assistant, featuring a highly-flexible Parametric Equalizer as its cornerstone component.
For a more thorough description, see music-assistant/server#1795.
Related Changes
This PR Depends on:
Implementation Details
Editing the DSP will automatically apply the new configuration after 2s of inactivity.
Manually accepting changes would be disadvantageous when editing EQs since immediate feedback is essential for fine-tuning audio settings and hearing the results in near-real-time.
To prevent accidental changes, a future PR will add support for saving and loading presets.
Future Work