Refactor letsrate model to fix rating on inherited models #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| if can_rate? user, dimension | ||
| rates(dimension).create! do |r| | ||
| r.stars = stars |
There was a problem hiding this comment.
this code was moved to a private method
|
@muratguzel please merge this PR so I can use the oficial version. Thanks for publishing this gem I really liked it. |
|
@muratguzel btw why do you use travis if you have no tests? |
|
I will add tests :) But yes you are right. And also I will check and merge you commit. Thanks |
|
Thanks @muratguzel :) |
|
hi all! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is need to fix a problem on on the rating cache that was saving the wrong
cacheable_typefor models. I also cleaned up the code to make it easier to understand. Please merge this for the next version.