Refactor letsrate model to fix rating on inherited models

[wazery]

Issue by 3den
Thursday Jan 09, 2014 at 23:01 GMT
Originally opened as muratguzel#60

---

This PR is need to fix a problem on on the rating cache that was saving the wrong cacheable_type for models. I also cleaned up the code to make it easier to understand. Please merge this for the next version.

---

3den included the following code: https://github.com/muratguzel/letsrate/pull/60/commits

[wazery]

Comment by 3den
Thursday Jan 09, 2014 at 23:06 GMT

---

@muratguzel please merge this PR so I can use the oficial version. Thanks for publishing this gem I really liked it.

[wazery]

Comment by 3den
Friday Jan 10, 2014 at 00:00 GMT

---

@muratguzel btw why do you use travis if you have no tests?

[wazery]

Comment by muratguzel
Tuesday Jan 21, 2014 at 08:29 GMT

---

I will add tests :) But yes you are right. And also I will check and merge you commit. Thanks

[wazery]

Comment by 3den
Tuesday Jan 21, 2014 at 08:34 GMT

---

Thanks @muratguzel :)

[wazery]

Comment by berkos
Tuesday Jun 10, 2014 at 17:02 GMT

---

hi all!
i was wondering,
is this still valid for merging?