Flexible configuration for chain simulator #21
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iulianpascalau
changed the title
miiu96
reviewed
Mar 22, 2024
pkg/proxy/api/endpoints.go
Outdated
| initialWalletsEndpoint = "/simulator/initial-wallets" | ||
| setKeyValuesEndpoint = "/simulator/address/:address/set-state" | ||
| setStateMultipleEndpoint = "/simulator/set-state" | ||
| addValidatorsKeys = "/simulator/add-keys" |
There was a problem hiding this comment.
can you please add also in the README file information about the new endpoints
There was a problem hiding this comment.
forgot about the README.md, added.
|
|
||
|
|
||
| if __name__ == "__main__": | ||
| main() |
miiu96
previously approved these changes
Mar 22, 2024
sstanculeanu
previously approved these changes
Mar 22, 2024
andreibancioiu
previously approved these changes
Mar 22, 2024
cmd/chainsimulator/flags.go
Outdated
| @@ -14,6 +14,11 @@ var ( | |||
| Usage: "The main configuration file to load", | |||
| Value: "./config/config.toml", | |||
| } | |||
| nodeOverrideConfigurationFile = cli.StringFlag{ | |||
config/tomlConfig_test.go
Outdated
| t.Parallel() | ||
|
|
||
| testString := ` | ||
| # OverridableConfigTomlValues represents an array of items to be overloaded inside other configuration files, which can be helpful |
There was a problem hiding this comment.
Test string can be shorter, to only have a short, dummy comment instead of the full description.
There was a problem hiding this comment.
made it shorter
There was a problem hiding this comment.
made it shorter here #21
|
|
||
| def main(): | ||
| # create a network provider | ||
| provider = ProxyNetworkProvider(SIMULATOR_URL) |
| provider = ProxyNetworkProvider(SIMULATOR_URL) | ||
|
|
||
| # generate blocks until we reach the epoch 10 | ||
| provider.do_post(f"{GENERATE_BLOCKS_UNTIL_EPOCH_REACHED_URL}/10", {}) |
There was a problem hiding this comment.
Could have been a constant. But perfectly fine as it is, in this context.
There was a problem hiding this comment.
added const here: #22
gabi-vuls
dismissed stale reviews from andreibancioiu, sstanculeanu, and miiu96
via
a443fcf
gabi-vuls
force-pushed
the
chain-simulator-custom-configs
branch
from
27dfa3e to
ba634bd
Compare
miiu96
changed the base branch from
rc/v1.7.0
to
chain-simulator-custom-configs-remade
Base automatically changed from
chain-simulator-custom-configs-remade
to
rc/v1.7.0
March 27, 2024 12:54
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-num-waiting-validators-per-shardand-num-waiting-validators-metaflags/simulator/generate-blocks-until-epoch-reachedendpoint route + .py example/simulator/force-reset-validator-statisticsendpoint route