-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added more files in the overridable configs options and chain simulator fixes #6054
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## rc/v1.7.0 #6054 +/- ##
=============================================
- Coverage 78.75% 78.74% -0.01%
=============================================
Files 752 752
Lines 97953 97971 +18
=============================================
+ Hits 77143 77150 +7
- Misses 15571 15581 +10
- Partials 5239 5240 +1 ☔ View full report in Codecov by Sentry. |
}) | ||
|
||
t.Run("should work for enableRounds.toml", func(t *testing.T) { | ||
// TODO: fix this test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe you can create a task for this TODO
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done, MX-15310
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Normal allin test: v1.6.15-dev-config-eb2e06c06d -> extend-overridable-configs-01caab9319
--- Specific errors ---
block hash does not match 2084
wrong nonce in block 956
miniblocks does not match 0
num miniblocks does not match 0
miniblock hash does not match 0
block bodies does not match 0
receipts hash missmatch 0
/------/
--- Statistics ---
Nr. of all ERRORS: 0
Nr. of all WARNS: 253
Nr. of new ERRORS: 0
Nr. of new WARNS: 0
Nr. of PANICS: 0
/------/
--- ERRORS ---
/------/
--- WARNINGS ---
/------/
Reasoning behind the pull request
helper PR for this: Flexible configuration for chain simulator mx-chain-simulator-go#21
Proposed changes
Testing procedure
Pre-requisites
Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:
feat
branch created?feat
branch merging, do all satellite projects have a proper tag insidego.mod
?