Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added more files in the overridable configs options and chain simulator fixes #6054

Merged
merged 6 commits into from
Mar 28, 2024

Conversation

iulianpascalau
Copy link
Contributor

@iulianpascalau iulianpascalau commented Mar 20, 2024

Reasoning behind the pull request

Proposed changes

Testing procedure

Pre-requisites

Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:

  • was the PR targeted to the correct branch?
  • if this is a larger feature that probably needs more than one PR, is there a feat branch created?
  • if this is a feat branch merging, do all satellite projects have a proper tag inside go.mod?

Copy link

codecov bot commented Mar 20, 2024

Codecov Report

Attention: Patch coverage is 41.37931% with 17 lines in your changes are missing coverage. Please review.

Project coverage is 78.74%. Comparing base (5b7797b) to head (ad0082c).

Files Patch % Lines
node/chainSimulator/configs/configs.go 0.00% 10 Missing ⚠️
node/chainSimulator/chainSimulator.go 0.00% 5 Missing ⚠️
config/overridableConfig/configOverriding.go 85.71% 2 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##           rc/v1.7.0    #6054      +/-   ##
=============================================
- Coverage      78.75%   78.74%   -0.01%     
=============================================
  Files            752      752              
  Lines          97953    97971      +18     
=============================================
+ Hits           77143    77150       +7     
- Misses         15571    15581      +10     
- Partials        5239     5240       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iulianpascalau iulianpascalau changed the title Added more files in the overridable configs options Added more files in the overridable configs options and chain simulator fixes Mar 20, 2024
})

t.Run("should work for enableRounds.toml", func(t *testing.T) {
// TODO: fix this test
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe you can create a task for this TODO

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done, MX-15310

Copy link
Contributor

@gabi-vuls gabi-vuls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Normal allin test: v1.6.15-dev-config-eb2e06c06d -> extend-overridable-configs-01caab9319

--- Specific errors ---

block hash does not match 2084
wrong nonce in block 956
miniblocks does not match 0
num miniblocks does not match 0
miniblock hash does not match 0
block bodies does not match 0
receipts hash missmatch 0

/------/

--- Statistics ---

Nr. of all ERRORS: 0
Nr. of all WARNS: 253
Nr. of new ERRORS: 0
Nr. of new WARNS: 0
Nr. of PANICS: 0

/------/

--- ERRORS ---

/------/

--- WARNINGS ---

/------/

@sstanculeanu sstanculeanu merged commit f634eaa into rc/v1.7.0 Mar 28, 2024
8 of 10 checks passed
@sstanculeanu sstanculeanu deleted the extend-overridable-configs-files branch March 28, 2024 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants